You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by st...@duboce.net on 2010/08/10 05:33:12 UTC

Re: Review Request: HBASE-2870: Add Backup CLI Option to HMaster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/592/#review793
-----------------------------------------------------------


I applied patch and built.  On shutdown of a standalone instance I got this:

"pynchon-305:trunk stack$ ./bin/stop-hbase.sh 
stopping hbase................../Users/stack/checkouts/trunk/bin/hbase-daemons.sh: line 49: /Users/stack/checkouts/trunk/bin/master-backup.sh: Permission denied
/Users/stack/checkouts/trunk/bin/hbase-daemons.sh: line 49: exec: /Users/stack/checkouts/trunk/bin/master-backup.sh: cannot execute: Unknown error: 0"

My script looks to have x perms:

pynchon-305:trunk stack$ ls -la bin/hbase-daemons.sh 
-rwxr-xr-x  1 stack  staff  1628 Aug  9 20:21 bin/hbase-daemons.sh

The passed 'args' are bad for standalone?


trunk/bin/master-backup.sh
<http://review.cloudera.org/r/592/#comment2668>

    I don't understand this construct Nicolas (My shell scripting requires me to have a book or a web page open while I write -- currently its not present).


- stack


On 2010-08-09 17:08:40, Nicolas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/592/
> -----------------------------------------------------------
> 
> (Updated 2010-08-09 17:08:40)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Adds '--backup' option to HMaster.  All backup masters will wait until a primary master has written the /hbase/master znode before poll waiting.  This allows us to have a deterministic primary master while starting up multiple masters.  Note that you can specify a list of backup masters to automatically start/stop via the 'conf/backup-masters' file.
> 
> 
> This addresses bug HBASE-2870.
>     http://issues.apache.org/jira/browse/HBASE-2870
> 
> 
> Diffs
> -----
> 
>   trunk/bin/hbase-config.sh 983803 
>   trunk/bin/hbase-daemons.sh 983803 
>   trunk/bin/local-master-backup.sh 983803 
>   trunk/bin/master-backup.sh PRE-CREATION 
>   trunk/bin/start-hbase.sh 983803 
>   trunk/bin/stop-hbase.sh 983803 
>   trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 983803 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 983803 
>   trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 983803 
> 
> Diff: http://review.cloudera.org/r/592/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>