You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4cxx-dev@logging.apache.org by Andreas Fester <An...@gmx.de> on 2005/06/01 21:25:43 UTC
Another small automake issue
Hi,
AC_CONFIG_HEADERS has been removed from configure.in,
but autoheader is still in autogen.sh ; do we still need
it? Tommi, you added AC_CONFIG_HEADERS([src/config.h])
in one of your patches, but since config.h is not included
anywhere (and according to include/log4cxx/helpers/tchar.h
*shall* not be included) it is probably correct to remove
autoheader from autogen.sh.
Best Regards,
Andreas
--
Andreas Fester
mailto:Andreas.Fester@gmx.de
WWW: http://littletux.homelinux.org
ICQ: 326674288
Re: Another small automake issue
Posted by Andreas Fester <An...@gmx.de>.
I think I also messed up something with the patch I sent
you yesterday (include/log4cxx/log4cxx.h is not generated correctly
anymore, I think it was not one of my better ideas to let you commit
only a part of Tommis patch :-( )
Anyway, what is still missing after your large commit is to add
the Makefile's in the new sub directories to configure.in:
Index: configure.in
===================================================================
RCS file: /home/cvspublic/logging-log4cxx/configure.in,v
retrieving revision 1.52
diff -u -r1.52 configure.in
--- configure.in 30 May 2005 13:30:18 -0000 1.52
+++ configure.in 1 Jun 2005 20:09:46 -0000
@@ -392,11 +392,14 @@
include/log4cxx/config/Makefile
include/log4cxx/db/Makefile
include/log4cxx/rolling/Makefile
+include/log4cxx/pattern/Makefile
+include/log4cxx/filter/Makefile
simplesocketserver/Makefile
tests/Makefile
tests/input/Makefile
tests/input/performance/Makefile
tests/input/ndc/Makefile
+tests/input/rolling/Makefile
tests/input/xml/Makefile
tests/src/Makefile
tests/src/customlogger/Makefile
@@ -411,6 +414,9 @@
tests/src/xml/Makefile
tests/src/varia/Makefile
tests/witness/Makefile
+tests/witness/encoding/Makefile
+tests/witness/ndc/Makefile
+tests/witness/rolling/Makefile
performance/Makefile
performance/xml/Makefile
examples/Makefile
I have not done a build yet, but at least
a "make dist" succeeds again with these directories added...
Curt Arnold wrote:
> You will likely have noticed a fairly large commit related to porting
> over the new RollingFileAppender framework from the log4j CVS HEAD. I
> tried to keep the Makefile.am's in synch, but it looks like I bungled
> something related to the include/log4cxx/pattern subdirectory. I would
> appreciate if someone could diagnose whatever I messed up. Thanks.
[...]
--
Andreas Fester
mailto:Andreas.Fester@gmx.de
WWW: http://littletux.homelinux.org
ICQ: 326674288
Re: Another small automake issue
Posted by Curt Arnold <ca...@apache.org>.
You will likely have noticed a fairly large commit related to porting
over the new RollingFileAppender framework from the log4j CVS HEAD.
I tried to keep the Makefile.am's in synch, but it looks like I
bungled something related to the include/log4cxx/pattern
subdirectory. I would appreciate if someone could diagnose whatever
I messed up. Thanks.
On Jun 1, 2005, at 2:25 PM, Andreas Fester wrote:
> Hi,
>
> AC_CONFIG_HEADERS has been removed from configure.in,
> but autoheader is still in autogen.sh ; do we still need
> it? Tommi, you added AC_CONFIG_HEADERS([src/config.h])
> in one of your patches, but since config.h is not included
> anywhere (and according to include/log4cxx/helpers/tchar.h
> *shall* not be included) it is probably correct to remove
> autoheader from autogen.sh.
>
> Best Regards,
>
> Andreas
>
> --
> Andreas Fester
> mailto:Andreas.Fester@gmx.de
> WWW: http://littletux.homelinux.org
> ICQ: 326674288
>