You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/07 17:01:25 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2479: Move `data-access` crate into `datafusion` directory
andygrove opened a new pull request, #2479:
URL: https://github.com/apache/arrow-datafusion/pull/2479
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/2424
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Make the project more consistent. All of the other datafusion sub-crates are under the datafusion directory and there appears to be no reason for `data-access` to be different.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Move `data-access` crate into `datafusion` directory
- Bump `data-access` version from 1.0.0 to 7.0.0 for consistency with other crates
- Update release scripts
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on pull request #2479: Move `data-access` crate into `datafusion` directory
Posted by GitBox <gi...@apache.org>.
jychen7 commented on PR #2479:
URL: https://github.com/apache/arrow-datafusion/pull/2479#issuecomment-1120599226
it looks like this PR just change the data-access code location (for easier crate building). But it doesn't change dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #2479: Move `data-access` crate into `datafusion` directory
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #2479:
URL: https://github.com/apache/arrow-datafusion/pull/2479#issuecomment-1120592147
Hi @andygrove, according to #2076, the reason to move the data-access crate out of the datafusion directory is to make it possible for other crates, like **datafusion-objectstore-s3** and **datafusion-objectstore-hdfs**, to depend on only this crate rather than the whole datafusion crate. Then the datafusion crate may also be able to depend on the object store extensions.
In summary, the data-access crate should not depend on the datafusion. The dependencies should be like follows:
```
datafusion
| \
| \
| datafusion-objectstore-extensions
| /
| /
data-access
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on pull request #2479: Move `data-access` crate into `datafusion` directory
Posted by GitBox <gi...@apache.org>.
jychen7 commented on PR #2479:
URL: https://github.com/apache/arrow-datafusion/pull/2479#issuecomment-1120339759
nice, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #2479: Move `data-access` crate into `datafusion` directory
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2479:
URL: https://github.com/apache/arrow-datafusion/pull/2479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2479: Move `data-access` crate into `datafusion` directory
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2479:
URL: https://github.com/apache/arrow-datafusion/pull/2479#issuecomment-1123113153
Thanks for the review @yjshen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2479: Move `data-access` crate into `datafusion` directory
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2479:
URL: https://github.com/apache/arrow-datafusion/pull/2479#issuecomment-1122576557
> it looks like this PR just change the data-access code location (for easier crate building). So it doesn't change dependencies
Yes, that is correct. This PR just moves the code and bumps the version from 1.0.0 to 7.0.0 for consistency with other DataFusion crates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org