You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wengzhe (via GitHub)" <gi...@apache.org> on 2023/12/13 04:46:21 UTC
[PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
wengzhe opened a new pull request, #11378:
URL: https://github.com/apache/nuttx/pull/11378
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #11378:
URL: https://github.com/apache/nuttx/pull/11378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
Posted by "PetteriAimonen (via GitHub)" <gi...@apache.org>.
PetteriAimonen commented on PR #11378:
URL: https://github.com/apache/nuttx/pull/11378#issuecomment-1853478847
I gave commit 9b06eba a quick test run, issues:
1. The main IPv6 address is not added to MAC filter if it is configured before ifup call. It looks like `netdev_ipv6_mcastmac()` never gets called for it.
2. Ping works to address added with `ifconfig eth0 inet6 add fd0f::e200` but gives warning:
<pre>
PING fd0f::e200(fd0f::e200) 56 data bytes
64 bytes from fd0f::e100: icmp_seq=2 ttl=64 time=0.171 ms (DIFFERENT ADDRESS!)
64 bytes from fd0f::e100: icmp_seq=3 ttl=64 time=0.187 ms (DIFFERENT ADDRESS!)
</pre>
3. TCP connections do not work because the response comes from wrong IP address.
Problems 2 and 3 exist prior to this commit. I think I'll try to make a fix for those, because TCP connections not working is a blocker for my application. I can assign IP addresses so that 4 last bytes are equal, so I'm fine with taking our time with the MAC filter fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11378:
URL: https://github.com/apache/nuttx/pull/11378#discussion_r1428809471
##########
net/icmpv6/Kconfig:
##########
@@ -8,6 +8,7 @@ menu "ICMPv6 Networking Support"
config NET_ICMPv6
bool "Enable ICMPv6 networking"
default n
+ select NET_MCASTGROUP
Review Comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11378:
URL: https://github.com/apache/nuttx/pull/11378#discussion_r1428649223
##########
net/icmpv6/Kconfig:
##########
@@ -8,6 +8,7 @@ menu "ICMPv6 Networking Support"
config NET_ICMPv6
bool "Enable ICMPv6 networking"
default n
+ select NET_MCASTGROUP
Review Comment:
should we change to depend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
Posted by "PetteriAimonen (via GitHub)" <gi...@apache.org>.
PetteriAimonen commented on PR #11378:
URL: https://github.com/apache/nuttx/pull/11378#issuecomment-1854014148
Commit 430289b now works quite well for me.
Our codebase actually is cutting some corners and writing directly into `dev->d_ipv6addr` before bringing up the interface.
I realize that it should use ioctl instead, and that is something I'm going to fix.
But even that seems to work ok now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
Posted by "wengzhe (via GitHub)" <gi...@apache.org>.
wengzhe commented on PR #11378:
URL: https://github.com/apache/nuttx/pull/11378#issuecomment-1853811718
> I gave commit 9b06eba a quick test run, issues:
>
> 1. The main IPv6 address is not added to MAC filter if it is configured before ifup call. It looks like `netdev_ipv6_mcastmac()` never gets called for it.
> 2. Ping works to address added with `ifconfig eth0 inet6 add fd0f::e200` but gives warning:
>
> PING fd0f::e200(fd0f::e200) 56 data bytes
> 64 bytes from fd0f::e100: icmp_seq=2 ttl=64 time=0.171 ms (DIFFERENT ADDRESS!)
> 64 bytes from fd0f::e100: icmp_seq=3 ttl=64 time=0.187 ms (DIFFERENT ADDRESS!)
> 3. TCP connections do not work because the response comes from wrong IP address.
>
> Problems 2 and 3 exist prior to this commit. I think I'll try to make a fix for those, because TCP connections not working is a blocker for my application. I can assign IP addresses so that 4 last bytes are equal, so I'm fine with taking our time with the MAC filter fix.
@PetteriAimonen Are you using netinit to initialize your main IPv6 address? I forgot to change the IOCTL `SIOCSLIFADDR` which is also left for backward compatibility and is used by netinit. You may try 430289b107 to see if it's correct now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
Posted by "wengzhe (via GitHub)" <gi...@apache.org>.
wengzhe commented on PR #11378:
URL: https://github.com/apache/nuttx/pull/11378#issuecomment-1854075184
> Commit [430289b](https://github.com/apache/nuttx/commit/430289b107f5be7dbfea8ef832ceb7796bd26297) now works quite well for me.
@PetteriAimonen Thanks for checking this commit, I'll polish this PR to a ready state this week.
> Our codebase actually is cutting some corners and writing directly into `dev->d_ipv6addr` before bringing up the interface. I realize that it should use ioctl instead, and that is something I'm going to fix. But even that seems to work ok now.
If you can access `dev->d_ipv6addr` directly, I think you might be working under kernel space, then just calling `netdev_ipv6_add` would be enough. If you're really under user space, I suggest you use existing netlib functions like `netlib_add_ipv6addr` or `netlib_set_ipv6addr`, wish you success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]
Posted by "wengzhe (via GitHub)" <gi...@apache.org>.
wengzhe commented on code in PR #11378:
URL: https://github.com/apache/nuttx/pull/11378#discussion_r1428746195
##########
net/icmpv6/Kconfig:
##########
@@ -8,6 +8,7 @@ menu "ICMPv6 Networking Support"
config NET_ICMPv6
bool "Enable ICMPv6 networking"
default n
+ select NET_MCASTGROUP
Review Comment:
`NET_MCASTGROUP` is not selectable by menuconfig. https://github.com/apache/nuttx/blob/06e5b661ed6b1d7480b9c30a27be502a08924bce/net/Kconfig#L40-L42
And both `NET_IGMP` and `NET_MLD` select it to enable `d_addmac` and `d_rmmac`. https://github.com/apache/nuttx/blob/06e5b661ed6b1d7480b9c30a27be502a08924bce/net/igmp/Kconfig#L6-L10
https://github.com/apache/nuttx/blob/06e5b661ed6b1d7480b9c30a27be502a08924bce/net/mld/Kconfig#L11
So I just let ICMPv6 keep the same as them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org