You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/11/28 17:45:18 UTC

Re: Review Request 53604: Added SeccompInfo protobuf message.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53604/#review157067
-----------------------------------------------------------




include/mesos/mesos.proto (lines 2066 - 2068)
<https://reviews.apache.org/r/53604/#comment227480>

    ```
     * Encapsulation for Linux seccomp filter.
     * TODO(jay_guo): Consider the compatibility issue stated in MESOS-4997.
     */
    ```



include/mesos/mesos.proto (line 2067)
<https://reviews.apache.org/r/53604/#comment227481>

    I think need add `UNKNOWN = 0;` to all enums.


- haosdent huang


On Nov. 25, 2016, 2:46 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53604/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 2:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
>     https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added SeccompInfo protobuf message.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 
>   include/mesos/slave/containerizer.proto 2621522ae59cf9275f607679b4678ac54508993d 
> 
> Diff: https://reviews.apache.org/r/53604/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>