[jira] [Commented] (FLINK-10842) Waiting loops are broken in e2e/common.sh

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681462#comment-16681462 ] 

ASF GitHub Bot commented on FLINK-10842:
----------------------------------------

azagrebin opened a new pull request #7073: [FLINK-10842][E2E tests] fix broken waiting loops in common.sh
URL: https://github.com/apache/flink/pull/7073
 
 
   ## What is the purpose of the change
   
   There are 3 loops in flink-end-to-end-tests/test-scripts/common.sh where the script waits for some event to happen (for i in {1..10}; do):
   
   wait_dispatcher_running
   start_and_wait_for_tm
   wait_job_running
   
   This PR changes them to fail if the expected event has not happened and to return from the loop if happened.
   
   ## Brief change log
   
     - change waiting loops in common.sh
   
   ## Verifying this change
   
   Run any relevant e2e tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Waiting loops are broken in e2e/common.sh
> -----------------------------------------
>
>                 Key: FLINK-10842
>                 URL: https://issues.apache.org/jira/browse/FLINK-10842
>             Project: Flink
>          Issue Type: Bug
>          Components: E2E Tests
>    Affects Versions: 1.7.0
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> There are 3 loops in flink-end-to-end-tests/test-scripts/common.sh where the script waits for some event to happen (for i in \{1..10}; do):
>  - wait_dispatcher_running
>  - start_and_wait_for_tm
>  - wait_job_running
> All loops have 10 iterations and the loop breaks if the awaited event happens. If timeout occurs then the script does not fail and the function just continues after 10 iterations ignoring that the awaited event did not happen.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)