You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/10/01 08:52:06 UTC
[GitHub] [skywalking] x22x22 opened a new pull request #5618: [WIP]Fix thread safety violation
x22x22 opened a new pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
Fix thread safety violation
- How to fix?
add synchronized or use Atomic Class
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1f79367417c2896cf3cc2b564830c62623833b4a?el=desc) will **decrease** coverage by `21.09%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.08% 26.99% -21.10%
+ Complexity 3127 1547 -1580
=============================================
Files 901 733 -168
Lines 22129 18089 -4040
Branches 2118 1649 -469
=============================================
- Hits 10641 4883 -5758
- Misses 10602 12869 +2267
+ Partials 886 337 -549
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `35.13% <0.00%> (-10.32%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [380 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [1f79367...358acc3](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `51.68%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 51.68% 0.00% -51.69%
============================================
Files 1608 170 -1438
Lines 34143 4034 -30109
Branches 3713 465 -3248
============================================
- Hits 17647 0 -17647
+ Misses 15641 4034 -11607
+ Partials 855 0 -855
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <ø> (-80.40%)` | `0.00 <0.00> (-10.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1576 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1f79367417c2896cf3cc2b564830c62623833b4a?el=desc) will **decrease** coverage by `22.04%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.08% 26.03% -22.05%
+ Complexity 3127 1476 -1651
=============================================
Files 901 716 -185
Lines 22129 17604 -4525
Branches 2118 1602 -516
=============================================
- Hits 10641 4584 -6057
- Misses 10602 12697 +2095
+ Partials 886 323 -563
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.23% <0.00%> (-11.23%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [402 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [1f79367...358acc3](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `21.03%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 51.68% 30.64% -21.04%
+ Complexity 3358 1986 -1372
=============================================
Files 1608 871 -737
Lines 34143 21405 -12738
Branches 3713 2052 -1661
=============================================
- Hits 17647 6560 -11087
+ Misses 15641 14359 -1282
+ Partials 855 486 -369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-31.42%)` | `7.00 <0.00> (-3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.28% <0.00%> (-18.67%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1224 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1f79367417c2896cf3cc2b564830c62623833b4a?el=desc) will **decrease** coverage by `20.10%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.08% 27.97% -20.11%
+ Complexity 3127 1622 -1505
=============================================
Files 901 733 -168
Lines 22129 18089 -4040
Branches 2118 1649 -469
=============================================
- Hits 10641 5061 -5580
- Misses 10602 12671 +2069
+ Partials 886 357 -529
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.23% <0.00%> (-11.23%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [1f79367...358acc3](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a36f22f828a1806d7ffe5d919dbd81e62fd852a3?el=desc) will **increase** coverage by `3.02%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
+ Coverage 48.77% 51.80% +3.02%
- Complexity 3154 3364 +210
============================================
Files 901 1606 +705
Lines 22129 34097 +11968
Branches 2118 3716 +1598
============================================
+ Hits 10793 17663 +6870
- Misses 10452 15579 +5127
+ Partials 884 855 -29
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `80.39% <ø> (+17.12%)` | `10.00 <0.00> (ø)` | |
| [...plugin/elasticsearch/v6/TransportAddressCache.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZWxhc3RpY3NlYXJjaC02LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZWxhc3RpY3NlYXJjaC92Ni9UcmFuc3BvcnRBZGRyZXNzQ2FjaGUuamF2YQ==) | `57.89% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `20.00% <ø> (+20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `78.26% <ø> (+78.26%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `70.23% <ø> (+70.23%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `89.24% <ø> (+18.27%)` | `19.00 <0.00> (+1.00)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `64.70% <80.00%> (-1.97%)` | `3.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `57.33% <100.00%> (+11.87%)` | `11.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1121 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [a36f22f...3aa9892](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `51.68%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 51.68% 0.00% -51.69%
============================================
Files 1608 169 -1439
Lines 34143 4030 -30113
Branches 3713 465 -3248
============================================
- Hits 17647 0 -17647
+ Misses 15641 4030 -11611
+ Partials 855 0 -855
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <ø> (-80.40%)` | `0.00 <0.00> (-10.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1576 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/f48e4961ec2d2f532132a1afe4e090d695347c50?el=desc) will **decrease** coverage by `11.02%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 39.65% 28.63% -11.03%
+ Complexity 2521 1621 -900
=============================================
Files 893 719 -174
Lines 22119 17827 -4292
Branches 2093 1615 -478
=============================================
- Hits 8772 5104 -3668
+ Misses 12705 12359 -346
+ Partials 642 364 -278
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.22% <0.00%> (-11.07%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [385 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [f48e496...edbaddc](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `0.46%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 51.68% 51.21% -0.47%
+ Complexity 3358 3310 -48
============================================
Files 1608 888 -720
Lines 34143 21953 -12190
Branches 3713 2102 -1611
============================================
- Hits 17647 11244 -6403
+ Misses 15641 9793 -5848
- Partials 855 916 +61
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `63.26% <ø> (-17.13%)` | `10.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.04% <0.00%> (-11.91%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `68.75% <100.00%> (+2.08%)` | `3.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1108 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/f48e4961ec2d2f532132a1afe4e090d695347c50?el=desc) will **decrease** coverage by `10.90%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 39.65% 28.75% -10.91%
+ Complexity 2521 1665 -856
=============================================
Files 893 736 -157
Lines 22119 18306 -3813
Branches 2093 1661 -432
=============================================
- Hits 8772 5263 -3509
+ Misses 12705 12674 -31
+ Partials 642 369 -273
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.22% <0.00%> (-11.07%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [f48e496...edbaddc](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `3.29%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 51.68% 48.39% -3.30%
+ Complexity 3358 3183 -175
============================================
Files 1608 888 -720
Lines 34143 21907 -12236
Branches 3713 2100 -1613
============================================
- Hits 17647 10601 -7046
+ Misses 15641 10436 -5205
- Partials 855 870 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `63.26% <ø> (-17.13%)` | `10.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.69% <0.00%> (-13.26%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `68.75% <100.00%> (+2.08%)` | `3.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1119 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a36f22f828a1806d7ffe5d919dbd81e62fd852a3?el=desc) will **decrease** coverage by `20.55%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.77% 28.21% -20.56%
+ Complexity 3154 1586 -1568
=============================================
Files 901 716 -185
Lines 22129 17610 -4519
Branches 2118 1603 -515
=============================================
- Hits 10793 4969 -5824
- Misses 10452 12276 +1824
+ Partials 884 365 -519
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `33.33% <0.00%> (-12.13%)` | `10.00 <0.00> (-1.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [393 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [a36f22f...23f0306](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/f48e4961ec2d2f532132a1afe4e090d695347c50?el=desc) will **decrease** coverage by `13.46%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 39.65% 26.19% -13.47%
+ Complexity 2521 1487 -1034
=============================================
Files 893 719 -174
Lines 22119 17827 -4292
Branches 2093 1615 -478
=============================================
- Hits 8772 4670 -4102
- Misses 12705 12819 +114
+ Partials 642 338 -304
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `33.33% <0.00%> (-11.96%)` | `10.00 <0.00> (-1.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [406 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [f48e496...edbaddc](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **increase** coverage by `1.09%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
+ Coverage 51.68% 52.77% +1.09%
- Complexity 3358 3364 +6
============================================
Files 1608 888 -720
Lines 34143 21953 -12190
Branches 3713 2102 -1611
============================================
- Hits 17647 11586 -6061
+ Misses 15641 9439 -6202
- Partials 855 928 +73
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `63.26% <ø> (-17.13%)` | `10.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `46.84% <0.00%> (-10.11%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `68.75% <100.00%> (+2.08%)` | `3.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1104 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **increase** coverage by `1.09%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
+ Coverage 51.68% 52.77% +1.09%
- Complexity 3358 3364 +6
============================================
Files 1608 888 -720
Lines 34143 21953 -12190
Branches 3713 2102 -1611
============================================
- Hits 17647 11586 -6061
+ Misses 15641 9439 -6202
- Partials 855 928 +73
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `63.26% <ø> (-17.13%)` | `10.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `46.84% <0.00%> (-10.11%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `68.75% <100.00%> (+2.08%)` | `3.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1104 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2c729b5d69b095962e7be5b8570eedc374659ec5?el=desc) will **decrease** coverage by `19.59%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.37% 28.77% -19.60%
+ Complexity 3208 1651 -1557
=============================================
Files 902 733 -169
Lines 22259 18089 -4170
Branches 2131 1649 -482
=============================================
- Hits 10767 5206 -5561
- Misses 10612 12518 +1906
+ Partials 880 365 -515
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `36.03% <0.00%> (-8.81%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (-3.23%)` | `18.00 <0.00> (-1.00)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00 <0.00> (-3.00)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [397 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [2c729b5...9c85e3e](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `21.55%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 51.68% 30.12% -21.56%
+ Complexity 3358 1953 -1405
=============================================
Files 1608 871 -737
Lines 34143 21377 -12766
Branches 3713 2047 -1666
=============================================
- Hits 17647 6440 -11207
+ Misses 15641 14455 -1186
+ Partials 855 482 -373
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-31.42%)` | `7.00 <0.00> (-3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.28% <0.00%> (-18.67%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (-18.28%)` | `18.00 <0.00> (-1.00)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1228 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a36f22f828a1806d7ffe5d919dbd81e62fd852a3?el=desc) will **decrease** coverage by `20.55%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.77% 28.21% -20.56%
+ Complexity 3154 1586 -1568
=============================================
Files 901 716 -185
Lines 22129 17610 -4519
Branches 2118 1603 -515
=============================================
- Hits 10793 4969 -5824
- Misses 10452 12276 +1824
+ Partials 884 365 -519
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `33.33% <0.00%> (-12.13%)` | `10.00 <0.00> (-1.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [393 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [a36f22f...b6ed9a5](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
+ Coverage 51.68% 51.80% +0.11%
- Complexity 3358 3364 +6
============================================
Files 1608 1606 -2
Lines 34143 34097 -46
Branches 3713 3716 +3
============================================
+ Hits 17647 17663 +16
+ Misses 15641 15579 -62
Partials 855 855
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `80.39% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...plugin/elasticsearch/v6/TransportAddressCache.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZWxhc3RpY3NlYXJjaC02LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZWxhc3RpY3NlYXJjaC92Ni9UcmFuc3BvcnRBZGRyZXNzQ2FjaGUuamF2YQ==) | `57.89% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `20.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `78.26% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `70.23% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `89.24% <ø> (ø)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `64.70% <80.00%> (-1.97%)` | `3.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `57.33% <100.00%> (+0.38%)` | `11.00 <0.00> (ø)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `51.68%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 51.68% 0.00% -51.69%
============================================
Files 1608 163 -1445
Lines 34143 3914 -30229
Branches 3713 446 -3267
============================================
- Hits 17647 0 -17647
+ Misses 15641 3914 -11727
+ Partials 855 0 -855
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <ø> (-80.40%)` | `0.00 <0.00> (-10.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1577 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#discussion_r498611103
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/boot/AgentPackagePath.java
##########
@@ -36,10 +36,12 @@
private static File AGENT_PACKAGE_PATH;
public static File getPath() throws AgentPackageNotFoundException {
- if (AGENT_PACKAGE_PATH == null) {
- AGENT_PACKAGE_PATH = findPath();
+ synchronized (AGENT_PACKAGE_PATH) {
Review comment:
*THREAD_SAFETY_VIOLATION:* Read/Write race. Non-private method `AgentPackagePath.getPath()` reads without synchronization from `boot.AgentPackagePath.AGENT_PACKAGE_PATH`. Potentially races with write in method `AgentPackagePath.getPath()`.
Reporting because this access may occur on a background thread.
##########
File path: apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/ConsumerPoolFactory.java
##########
@@ -18,20 +18,19 @@
package org.apache.skywalking.apm.commons.datacarrier.consumer;
-import java.util.HashMap;
-import java.util.Map;
import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentHashMap;
/**
* Consumer Pool Factory provides global management for all Consumer Pool.
*/
public enum ConsumerPoolFactory {
INSTANCE;
- private final Map<String, ConsumerPool> pools;
+ private final ConcurrentHashMap<String, ConsumerPool> pools;
Review comment:
*ImmutableEnumChecker:* enums should be immutable: 'ConsumerPoolFactory' has field 'pools' of type 'java.util.concurrent.ConcurrentHashMap<java.lang.String,org.apache.skywalking.apm.commons.datacarrier.consumer.ConsumerPool>', the declaration of type 'java.util.concurrent.ConcurrentHashMap<java.lang.String,org.apache.skywalking.apm.commons.datacarrier.consumer.ConsumerPool>' is not annotated with @com.google.errorprone.annotations.Immutable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a36f22f828a1806d7ffe5d919dbd81e62fd852a3?el=desc) will **decrease** coverage by `20.55%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.77% 28.21% -20.56%
+ Complexity 3154 1586 -1568
=============================================
Files 901 716 -185
Lines 22129 17610 -4519
Branches 2118 1603 -515
=============================================
- Hits 10793 4969 -5824
- Misses 10452 12276 +1824
+ Partials 884 365 -519
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `33.33% <0.00%> (-12.13%)` | `10.00 <0.00> (-1.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [393 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [a36f22f...4fd4211](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a36f22f828a1806d7ffe5d919dbd81e62fd852a3?el=desc) will **decrease** coverage by `23.18%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.77% 25.59% -23.19%
+ Complexity 3154 1454 -1700
=============================================
Files 901 716 -185
Lines 22129 17604 -4525
Branches 2118 1602 -516
=============================================
- Hits 10793 4505 -6288
- Misses 10452 12773 +2321
+ Partials 884 326 -558
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `33.33% <0.00%> (-12.13%)` | `10.00 <0.00> (-1.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [411 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [a36f22f...4fd4211](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `51.68%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 51.68% 0.00% -51.69%
============================================
Files 1608 168 -1440
Lines 34143 3958 -30185
Branches 3713 448 -3265
============================================
- Hits 17647 0 -17647
+ Misses 15641 3958 -11683
+ Partials 855 0 -855
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <ø> (-80.40%)` | `0.00 <0.00> (-10.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1577 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2c729b5d69b095962e7be5b8570eedc374659ec5?el=desc) will **decrease** coverage by `19.62%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.37% 28.74% -19.63%
+ Complexity 3208 1659 -1549
=============================================
Files 902 736 -166
Lines 22259 18201 -4058
Branches 2131 1657 -474
=============================================
- Hits 10767 5232 -5535
- Misses 10612 12602 +1990
+ Partials 880 367 -513
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.22% <0.00%> (-10.63%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (-3.23%)` | `18.00 <0.00> (-1.00)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00 <0.00> (-3.00)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [388 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [2c729b5...9c85e3e](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a36f22f828a1806d7ffe5d919dbd81e62fd852a3?el=desc) will **decrease** coverage by `21.77%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.77% 26.99% -21.78%
+ Complexity 3154 1547 -1607
=============================================
Files 901 733 -168
Lines 22129 18089 -4040
Branches 2118 1649 -469
=============================================
- Hits 10793 4883 -5910
- Misses 10452 12869 +2417
+ Partials 884 337 -547
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `35.13% <0.00%> (-10.32%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [386 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [a36f22f...b6ed9a5](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1f79367417c2896cf3cc2b564830c62623833b4a?el=desc) will **decrease** coverage by `19.30%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.08% 28.77% -19.31%
+ Complexity 3127 1651 -1476
=============================================
Files 901 733 -168
Lines 22129 18089 -4040
Branches 2118 1649 -469
=============================================
- Hits 10641 5206 -5435
- Misses 10602 12518 +1916
+ Partials 886 365 -521
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `36.03% <0.00%> (-9.42%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [367 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [1f79367...358acc3](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `0.63%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 51.68% 51.05% -0.64%
+ Complexity 3358 3300 -58
============================================
Files 1608 888 -720
Lines 34143 21953 -12190
Branches 3713 2102 -1611
============================================
- Hits 17647 11208 -6439
+ Misses 15641 9832 -5809
- Partials 855 913 +58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `63.26% <ø> (-17.13%)` | `10.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.04% <0.00%> (-11.91%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `68.75% <100.00%> (+2.08%)` | `3.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1108 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **increase** coverage by `1.04%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
+ Coverage 51.68% 52.72% +1.04%
- Complexity 3358 3360 +2
============================================
Files 1608 888 -720
Lines 34143 21953 -12190
Branches 3713 2102 -1611
============================================
- Hits 17647 11575 -6072
+ Misses 15641 9451 -6190
- Partials 855 927 +72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `63.26% <ø> (-17.13%)` | `10.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `46.84% <0.00%> (-10.11%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `68.75% <100.00%> (+2.08%)` | `3.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1105 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1f79367417c2896cf3cc2b564830c62623833b4a?el=desc) will **decrease** coverage by `19.30%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.08% 28.77% -19.31%
+ Complexity 3127 1651 -1476
=============================================
Files 901 733 -168
Lines 22129 18089 -4040
Branches 2118 1649 -469
=============================================
- Hits 10641 5206 -5435
- Misses 10602 12518 +1916
+ Partials 886 365 -521
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `36.03% <0.00%> (-9.42%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [367 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [1f79367...358acc3](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `12.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 51.68% 39.20% -12.48%
+ Complexity 3358 2452 -906
=============================================
Files 1608 871 -737
Lines 34143 21428 -12715
Branches 3713 2054 -1659
=============================================
- Hits 17647 8401 -9246
+ Misses 15641 12412 -3229
+ Partials 855 615 -240
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-31.42%)` | `7.00 <0.00> (-3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.69% <0.00%> (-13.26%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1183 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] x22x22 commented on a change in pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
x22x22 commented on a change in pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#discussion_r498630900
##########
File path: apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/ConsumeDriver.java
##########
@@ -91,7 +91,7 @@ public void begin(Channels channels) {
}
@Override
- public boolean isRunning(Channels channels) {
+ public synchronized boolean isRunning(Channels channels) {
return running;
}
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `18.39%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 51.68% 33.29% -18.40%
+ Complexity 3358 2143 -1215
=============================================
Files 1608 871 -737
Lines 34143 21408 -12735
Branches 3713 2052 -1661
=============================================
- Hits 17647 7127 -10520
+ Misses 15641 13780 -1861
+ Partials 855 501 -354
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-31.42%)` | `7.00 <0.00> (-3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.69% <0.00%> (-13.26%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a36f22f828a1806d7ffe5d919dbd81e62fd852a3?el=desc) will **decrease** coverage by `22.32%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.77% 26.45% -22.33%
+ Complexity 3154 1517 -1637
=============================================
Files 901 733 -168
Lines 22129 18089 -4040
Branches 2118 1649 -469
=============================================
- Hits 10793 4785 -6008
- Misses 10452 12964 +2512
+ Partials 884 340 -544
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `35.13% <0.00%> (-10.32%)` | `10.00 <0.00> (-1.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [395 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [a36f22f...b6ed9a5](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/f48e4961ec2d2f532132a1afe4e090d695347c50?el=desc) will **decrease** coverage by `10.90%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 39.65% 28.75% -10.91%
+ Complexity 2521 1665 -856
=============================================
Files 893 736 -157
Lines 22119 18306 -3813
Branches 2093 1661 -432
=============================================
- Hits 8772 5263 -3509
+ Misses 12705 12674 -31
+ Partials 642 369 -273
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.22% <0.00%> (-11.07%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [f48e496...edbaddc](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `20.04%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 51.68% 31.63% -20.05%
+ Complexity 3358 2049 -1309
=============================================
Files 1608 871 -737
Lines 34143 21405 -12738
Branches 3713 2052 -1661
=============================================
- Hits 17647 6772 -10875
+ Misses 15641 14141 -1500
+ Partials 855 492 -363
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-31.42%)` | `7.00 <0.00> (-3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.69% <0.00%> (-13.26%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1215 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/f48e4961ec2d2f532132a1afe4e090d695347c50?el=desc) will **decrease** coverage by `10.91%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 39.65% 28.74% -10.92%
+ Complexity 2521 1659 -862
=============================================
Files 893 736 -157
Lines 22119 18201 -3918
Branches 2093 1657 -436
=============================================
- Hits 8772 5232 -3540
+ Misses 12705 12602 -103
+ Partials 642 367 -275
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.22% <0.00%> (-11.07%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [384 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [f48e496...edbaddc](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a36f22f828a1806d7ffe5d919dbd81e62fd852a3?el=desc) will **decrease** coverage by `20.55%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.77% 28.21% -20.56%
+ Complexity 3154 1586 -1568
=============================================
Files 901 716 -185
Lines 22129 17610 -4519
Branches 2118 1603 -515
=============================================
- Hits 10793 4969 -5824
- Misses 10452 12276 +1824
+ Partials 884 365 -519
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `33.33% <0.00%> (-12.13%)` | `10.00 <0.00> (-1.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [393 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [a36f22f...4fd4211](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1f79367417c2896cf3cc2b564830c62623833b4a?el=desc) will **decrease** coverage by `21.09%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.08% 26.99% -21.10%
+ Complexity 3127 1547 -1580
=============================================
Files 901 733 -168
Lines 22129 18089 -4040
Branches 2118 1649 -469
=============================================
- Hits 10641 4883 -5758
- Misses 10602 12869 +2267
+ Partials 886 337 -549
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `35.13% <0.00%> (-10.32%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [380 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [1f79367...358acc3](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
+ Coverage 51.68% 51.80% +0.11%
- Complexity 3358 3364 +6
============================================
Files 1608 1606 -2
Lines 34143 34097 -46
Branches 3713 3716 +3
============================================
+ Hits 17647 17663 +16
+ Misses 15641 15579 -62
Partials 855 855
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `80.39% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...plugin/elasticsearch/v6/TransportAddressCache.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZWxhc3RpY3NlYXJjaC02LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZWxhc3RpY3NlYXJjaC92Ni9UcmFuc3BvcnRBZGRyZXNzQ2FjaGUuamF2YQ==) | `57.89% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `20.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `78.26% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `70.23% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `89.24% <ø> (ø)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `64.70% <80.00%> (-1.97%)` | `3.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `57.33% <100.00%> (+0.38%)` | `11.00 <0.00> (ø)` | |
| [...g/oap/server/telemetry/api/HealthCheckMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvYXBpL0hlYWx0aENoZWNrTWV0cmljcy5qYXZh) | `70.00% <0.00%> (-30.00%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...0586dbf](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on a change in pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#discussion_r498301488
##########
File path: apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/ConsumeDriver.java
##########
@@ -91,7 +91,7 @@ public void begin(Channels channels) {
}
@Override
- public boolean isRunning(Channels channels) {
+ public synchronized boolean isRunning(Channels channels) {
return running;
}
Review comment:
I think that to change to a `volatile` variable is enough. I mean replacing `boolean running` with `volatile boolean running`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `15.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 51.68% 36.46% -15.22%
+ Complexity 3358 2308 -1050
=============================================
Files 1608 871 -737
Lines 34143 21428 -12715
Branches 3713 2054 -1659
=============================================
- Hits 17647 7814 -9833
+ Misses 15641 13061 -2580
+ Partials 855 553 -302
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-31.42%)` | `7.00 <0.00> (-3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.69% <0.00%> (-13.26%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `61.53% <ø> (+61.53%)` | `3.00 <0.00> (+3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1192 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `19.32%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 51.68% 32.36% -19.33%
+ Complexity 3358 2092 -1266
=============================================
Files 1608 871 -737
Lines 34143 21405 -12738
Branches 3713 2052 -1661
=============================================
- Hits 17647 6927 -10720
+ Misses 15641 13977 -1664
+ Partials 855 501 -354
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-31.42%)` | `7.00 <0.00> (-3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.69% <0.00%> (-13.26%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `74.19% <ø> (-15.06%)` | `19.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1212 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6f99a24c43c5f2a976c37efd180249304b0a9c99?el=desc) will **decrease** coverage by `22.34%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 51.68% 29.34% -22.35%
+ Complexity 3358 1885 -1473
=============================================
Files 1608 871 -737
Lines 34143 21334 -12809
Branches 3713 2044 -1669
=============================================
- Hits 17647 6260 -11387
+ Misses 15641 14609 -1032
+ Partials 855 465 -390
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-31.42%)` | `7.00 <0.00> (-3.00)` | |
| [...king/apm/agent/core/plugin/WitnessClassFinder.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NDbGFzc0ZpbmRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `31.98% <0.00%> (-24.97%)` | `9.00 <0.00> (-2.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (-20.00%)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (-78.27%)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <ø> (-70.24%)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (-18.28%)` | `18.00 <0.00> (-1.00)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [6f99a24...fecff1d](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2c729b5d69b095962e7be5b8570eedc374659ec5?el=desc) will **decrease** coverage by `22.32%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.37% 26.04% -22.33%
+ Complexity 3208 1484 -1724
=============================================
Files 902 719 -183
Lines 22259 17716 -4543
Branches 2131 1610 -521
=============================================
- Hits 10767 4614 -6153
- Misses 10612 12778 +2166
+ Partials 880 324 -556
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.22% <0.00%> (-10.63%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (-3.23%)` | `18.00 <0.00> (-1.00)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00 <0.00> (-3.00)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [426 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [2c729b5...9c85e3e](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: [WIP]Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1f79367417c2896cf3cc2b564830c62623833b4a?el=desc) will **decrease** coverage by `21.63%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.08% 26.45% -21.64%
+ Complexity 3127 1517 -1610
=============================================
Files 901 733 -168
Lines 22129 18089 -4040
Branches 2118 1649 -469
=============================================
- Hits 10641 4785 -5856
- Misses 10602 12964 +2362
+ Partials 886 340 -546
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `35.13% <0.00%> (-10.32%)` | `10.00 <0.00> (-1.00)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [389 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [1f79367...358acc3](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5618: Fix thread safety violation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5618:
URL: https://github.com/apache/skywalking/pull/5618#issuecomment-702001032
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=h1) Report
> Merging [#5618](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2c729b5d69b095962e7be5b8570eedc374659ec5?el=desc) will **decrease** coverage by `19.74%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5618 +/- ##
=============================================
- Coverage 48.37% 28.62% -19.75%
+ Complexity 3208 1615 -1593
=============================================
Files 902 719 -183
Lines 22259 17722 -4537
Branches 2131 1611 -520
=============================================
- Hits 10767 5073 -5694
- Misses 10612 12287 +1675
+ Partials 880 362 -518
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <ø> (-14.29%)` | `7.00 <0.00> (-3.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.22% <0.00%> (-10.63%)` | `11.00 <0.00> (ø)` | |
| [...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ap/server/core/remote/client/GRPCRemoteClient.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9HUlBDUmVtb3RlQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.96% <ø> (-3.23%)` | `18.00 <0.00> (-1.00)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00 <0.00> (-3.00)` | |
| [...mons/datacarrier/consumer/ConsumerPoolFactory.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyUG9vbEZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `18.18% <100.00%> (-37.38%)` | `4.00 <0.00> (-5.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [402 more](https://codecov.io/gh/apache/skywalking/pull/5618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=footer). Last update [2c729b5...9c85e3e](https://codecov.io/gh/apache/skywalking/pull/5618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org