You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/28 14:31:14 UTC
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request
#15760: Fix PR #15489 (Dynamic Library Loading Support)
samskalicky commented on a change in pull request #15760: Fix PR #15489 (Dynamic Library Loading Support)
URL: https://github.com/apache/incubator-mxnet/pull/15760#discussion_r361797773
##########
File path: Makefile
##########
@@ -659,6 +659,9 @@ cpplint:
pylint:
python3 -m pylint --rcfile=$(ROOTDIR)/ci/other/pylintrc --ignore-patterns=".*\.so$$,.*\.dll$$,.*\.dylib$$" python/mxnet tools/caffe_converter/*.py
+sample_lib:
+ $(CXX) -shared -fPIC example/lib_api/mylib.cc -o libsample_lib.so -I include/mxnet
Review comment:
@TaoLv this has been fixed in the custom Op PR from @rondogency by adding entries to the clean target:
https://github.com/apache/incubator-mxnet/pull/15921/files#diff-b67911656ef5d18c4ae36cb6741b7965R763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services