You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "johnjcasey (via GitHub)" <gi...@apache.org> on 2023/06/06 17:11:40 UTC
[GitHub] [beam] johnjcasey opened a new pull request, #27032: Factor out the SubscriptionPartitionRestrictionTracker and add a hasP…
johnjcasey opened a new pull request, #27032:
URL: https://github.com/apache/beam/pull/27032
…rogress implementation
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1581230250
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey merged pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey merged PR #27032:
URL: https://github.com/apache/beam/pull/27032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1599413991
the failing tests are flakes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27032: Factor out the SubscriptionPartitionRestrictionTracker and add a hasP…
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1579331349
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on a diff in pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on code in PR #27032:
URL: https://github.com/apache/beam/pull/27032#discussion_r1227471511
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java:
##########
@@ -432,7 +432,7 @@ public static <InputT, OutputT> double invokeGetSize(
.getProgress()
.getWorkRemaining();
} else {
- return 1.0;
+ return 0.0;
Review Comment:
Maybe adding a comment with the rationale for returning 0 will be useful for the next person
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1583119883
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on a diff in pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on code in PR #27032:
URL: https://github.com/apache/beam/pull/27032#discussion_r1229242205
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java:
##########
@@ -432,7 +432,7 @@ public static <InputT, OutputT> double invokeGetSize(
.getProgress()
.getWorkRemaining();
} else {
- return 1.0;
+ return 0.0;
Review Comment:
Please update the comment where the interface is defined, as it explicitly states 1.0. The comment requested above would be better there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27032: Factor out the SubscriptionPartitionRestrictionTracker and add a hasP…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1579230045
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @bvolpato for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27032: Factor out the SubscriptionPartitionRestrictionTracker and add a hasP…
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1579184623
@dpcollins-google @scwhittle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on a diff in pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on code in PR #27032:
URL: https://github.com/apache/beam/pull/27032#discussion_r1229245310
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java:
##########
@@ -432,7 +432,7 @@ public static <InputT, OutputT> double invokeGetSize(
.getProgress()
.getWorkRemaining();
} else {
- return 1.0;
+ return 0.0;
Review Comment:
I'm referring to the DoFnInvoker.invokeGetSize comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1587659306
Both failing tests appear to be unrelated flakes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1581166631
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1588452188
Run Java_PVR_Flink_Batch PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #27032: Change default work remaining to 0.0 instead of 1.0
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1588452346
Run Java_Pulsar_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #27032: Factor out the SubscriptionPartitionRestrictionTracker and add a hasP…
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on PR #27032:
URL: https://github.com/apache/beam/pull/27032#issuecomment-1580211612
IIUC this is just to ensure that we don't report a backlog size for the SDF which happens if hasProgress isn't implemented?
If so, could we change the behavior of without hasProgress from returning 1.0 to 0 in invokeGetSize here
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnInvoker.java ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org