You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/14 15:30:44 UTC

[GitHub] [apisix] bisakhmondal commented on pull request #6314: fix(hmac-auth): hmac-auth plugin sort array param

bisakhmondal commented on pull request #6314:
URL: https://github.com/apache/apisix/pull/6314#issuecomment-1039222683


   Hi! Thanks for detecting the issue and the PR.
   After looking into the codebase, I find the way of forming the canonical query string unnecessarily complex yet it's not accurate. 
   I would go with a simpler approach rather than pathing this up. 
   
   We can replace:
   https://github.com/apache/apisix/blob/605141cba33beccf71100fdea03c8e9608d4852f/apisix/plugins/hmac-auth.lua#L219-L255
   with 
   https://github.com/apache/apisix/blob/605141cba33beccf71100fdea03c8e9608d4852f/apisix/plugins/aws-lambda.lua#L123-L130
   It's very simple, yet effective.
   cc @spacewander to share your views.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org