You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/01/19 20:09:26 UTC

Review Request 55727: Checkpoint and track docker image layer sizes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55727/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-6893
    https://issues.apache.org/jira/browse/MESOS-6893


Repository: mesos


Description
-------

This patch added the following capabilities:
1. add the size and fetch timestamp of each docker image layer in metadata;
2. checkpoint and recover size (timestamp will be added later);
3. reuse the `DiskUsageCollector` class to track size of each downloaded store;
4. for upgrade path, reuse same collector to back fill the size of layers.

Tests to be added later. Sending out review for earlier feedback.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/message.proto c93c7a92ec152bd9747a70392adfe6a0e863e839 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 395c36b0f6b8f8e037681ec5f2df99e83a7cf155 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 

Diff: https://reviews.apache.org/r/55727/diff/


Testing
-------


Thanks,

Zhitao Li

Re: Review Request 55727: Checkpoint and track docker image layer sizes.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55727/#review162375
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53105, 53330, 55727]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 19, 2017, 8:09 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55727/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 8:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-6893
>     https://issues.apache.org/jira/browse/MESOS-6893
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch added the following capabilities:
> 1. add the size and fetch timestamp of each docker image layer in metadata;
> 2. checkpoint and recover size (timestamp will be added later);
> 3. reuse the `DiskUsageCollector` class to track size of each downloaded store;
> 4. for upgrade path, reuse same collector to back fill the size of layers.
> 
> Tests to be added later. Sending out review for earlier feedback.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto c93c7a92ec152bd9747a70392adfe6a0e863e839 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 395c36b0f6b8f8e037681ec5f2df99e83a7cf155 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 
> 
> Diff: https://reviews.apache.org/r/55727/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 55727: Checkpoint and track docker image layer sizes.

Posted by Zhitao Li <zh...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55727/
-----------------------------------------------------------

(Updated Nov. 16, 2017, 5:43 p.m.)

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.

Bugs: MESOS-6893
https://issues.apache.org/jira/browse/MESOS-6893

Repository: mesos

Description
-------

This patch added the following capabilities:
1. add the size and fetch timestamp of each docker image layer in metadata;
2. checkpoint and recover size (timestamp will be added later);
3. reuse the `DiskUsageCollector` class to track size of each downloaded store;
4. for upgrade path, reuse same collector to back fill the size of layers
asynchronously without blocking `recover()`;
5. a counter for number of layers pulled;
6. a gauge for total number of layers;
7. a timer for pull latency distribution in the last hour.

Diffs
-----

src/slave/containerizer/mesos/provisioner/docker/message.proto a55ac9010d5e5b5691ec34b6c342e57811aee4ce
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
src/slave/containerizer/mesos/provisioner/docker/store.cpp 8058dcb31b9de59fa8d3638b5511113632235542

Diff: https://reviews.apache.org/r/55727/diff/4/

Testing
-------

Thanks,

Zhitao Li

Re: Review Request 55727: Checkpoint and track docker image layer sizes.

Posted by Zhitao Li <zh...@gmail.com>.

(Updated June 1, 2017, 8:38 a.m.)

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.

Changes
-------

Fix recover case for upgrade.

Bugs: MESOS-6893
https://issues.apache.org/jira/browse/MESOS-6893

Repository: mesos

Description (updated)
-------

Diffs (updated)
-----

Diff: https://reviews.apache.org/r/55727/diff/4/

Changes: https://reviews.apache.org/r/55727/diff/3-4/

Testing
-------

Thanks,

Zhitao Li

Re: Review Request 55727: Checkpoint and track docker image layer sizes.

Posted by Zhitao Li <zh...@gmail.com>.

(Updated May 31, 2017, 6 p.m.)

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.

Changes
-------

Rebase and merge layers metrics.

Bugs: MESOS-6893
https://issues.apache.org/jira/browse/MESOS-6893

Repository: mesos

Description (updated)
-------

This patch added the following capabilities:
1. add the size and fetch timestamp of each docker image layer in metadata;
2. checkpoint and recover size (timestamp will be added later);
3. reuse the `DiskUsageCollector` class to track size of each downloaded store;
4. for upgrade path, reuse same collector to back fill the size of layers.
5. a counter for number of layers pulled
6. a gauge for total number of layers
7. a timer for pull latency distribution in the last hour

Tests to be added later. Sending out review for earlier feedback.

Diffs (updated)
-----

Diff: https://reviews.apache.org/r/55727/diff/3/

Changes: https://reviews.apache.org/r/55727/diff/2-3/

Testing
-------

Thanks,

Zhitao Li

Re: Review Request 55727: Checkpoint and track docker image layer sizes.

Posted by Zhitao Li <zh...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55727/
-----------------------------------------------------------

(Updated Feb. 15, 2017, 9:15 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-6893
    https://issues.apache.org/jira/browse/MESOS-6893


Repository: mesos


Description
-------

This patch added the following capabilities:
1. add the size and fetch timestamp of each docker image layer in metadata;
2. checkpoint and recover size (timestamp will be added later);
3. reuse the `DiskUsageCollector` class to track size of each downloaded store;
4. for upgrade path, reuse same collector to back fill the size of layers.

Tests to be added later. Sending out review for earlier feedback.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/message.proto c93c7a92ec152bd9747a70392adfe6a0e863e839 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 

Diff: https://reviews.apache.org/r/55727/diff/


Testing
-------


Thanks,

Zhitao Li