You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Carsten Pieper <ca...@continentale.de> on 2009/09/10 14:45:31 UTC

[TRINIDAD] Configure texts for detailStamp facet in tr:table

Hello,

we'd like to use tr:table with facet "detailStamp" but are not particularly
happy with the
default texts that come with it. In the CoreBundle.xrts (or, in our case,
the CoreBundle_de.xrts)
you find entries with the following keys:

af_table.DISCLOSED
af_table.UNDISCLOSED
af_table.DISCLOSED_TIP
af_table.UNDISCLOSED_TIP

By overwriting these in our local Trinidad build, I thought to change the
texts for our
szenario but it didn't work out. In fact, the "normal" showDetail entries

af_showDetailHeader.DISCLOSED
af_showDetailHeader.UNDISCLOSED
af_showDetailHeader.DISCLOSED_TIP
af_showDetailHeader.UNDISCLOSED_TIP

seem to be used for facet detailStamp, too... :-O

Any ideas welcome, thanks,
Carsten

PS Asked this same question on the users' forum, but (as no one answered) 
wondered if it wouldn't fit better in here...
-- 
View this message in context: http://www.nabble.com/-TRINIDAD--Configure-texts-for-detailStamp-facet-in-tr%3Atable-tp25382677p25382677.html
Sent from the My Faces - Dev mailing list archive at Nabble.com.


Re: [TRINIDAD] Configure texts for detailStamp facet in tr:table

Posted by Carsten Pieper <ca...@continentale.de>.
No replies, so far, hm...

Doesn't anyone know about these things anymore or is the question too 
stupid (without me seeing it...)? To me, it still feels like a bug, but I 
thought it's better to ask here before filing a JIRA ticket...

Carsten


Carsten Pieper wrote:
> 
> Hi, I forgot to mention, that we're on Trinidad 1.0.10. When I look into
> the 
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtmlTableRenderer, 
> I find this:
> 
>   protected Map<String, String> createResourceKeyMap()
>   {
>     // map the skin resource keys that are used in components used
>     // by the table renderer to table keys.
>     // This way the table can be customized separately from other
>     // components that it uses within it. For example, we can customize
>     // af_table.DISCLOSED translation key
>     // separately from af_showDetail.DISCLOSED.
>     Map<String, String> map = new HashMap<String, String>(6);
>     map.put("af_showDetail.DISCLOSED",
>             "af_table.DISCLOSED");
>     map.put("af_showDetail.UNDISCLOSED",
>             "af_table.UNDISCLOSED");
>     map.put("af_showDetail.DISCLOSED_TIP",
>             "af_table.DISCLOSED_TIP");
>     map.put("af_showDetail.UNDISCLOSED_TIP",
>             "af_table.UNDISCLOSED_TIP");
> 
>     // ... more map entries to follow, but not hard coded as above
>     // but via SkinSelecors, like this:
>     //    map.put(SkinSelectors.AF_SHOW_DETAIL_DISCLOSED_ICON_NAME,
>     //       SkinSelectors.AF_TABLE_SD_DISCLOSED_ICON_NAME);
>     //     ...
> 
>   }
> 
> The original inline comment explicitly says, that the key
> "af_table.DISCLOSED"
> (table mit facet="detailStamp"), could be configured separately from
> af_showDetail.DISCLOSED (showDetail) - only that it doesn't work, at least
> not for me.
> 
> One thought, though. Would't the hardcoded skelektors (first 4 map entries
> here) in this code
> be a problem when "stylesheet compression" is turned on (in the web.xml
> via
> 	<context-param>
> 	
> <param-name>org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION</param-name>
> 		<param-value>true</param-value>
> 	</context-param>
> )?
> 
> Cheers, Carsten
> 
> 
> Carsten Pieper wrote:
>> 
>> Hello,
>> 
>> we'd like to use tr:table with facet "detailStamp" but are not
>> particularly happy with the
>> default texts that come with it. In the CoreBundle.xrts (or, in our case,
>> the CoreBundle_de.xrts)
>> you find entries with the following keys:
>> 
>> af_table.DISCLOSED
>> af_table.UNDISCLOSED
>> af_table.DISCLOSED_TIP
>> af_table.UNDISCLOSED_TIP
>> 
>> By overwriting these in our local Trinidad build, I thought to change the
>> texts for our
>> szenario but it didn't work out. In fact, the "normal" showDetail entries
>> 
>> af_showDetailHeader.DISCLOSED
>> af_showDetailHeader.UNDISCLOSED
>> af_showDetailHeader.DISCLOSED_TIP
>> af_showDetailHeader.UNDISCLOSED_TIP
>> 
>> seem to be used for facet detailStamp, too... :-O
>> 
>> Any ideas welcome, thanks,
>> Carsten
>> 
>> PS Asked this same question on the users' forum, but (as no one answered) 
>> wondered if it wouldn't fit better in here...
>> 
> 
> 

-- 
View this message in context: http://www.nabble.com/-TRINIDAD--Configure-texts-for-detailStamp-facet-in-tr%3Atable-tp25382677p25430805.html
Sent from the My Faces - Dev mailing list archive at Nabble.com.


Re: [TRINIDAD] Configure texts for detailStamp facet in tr:table

Posted by Carsten Pieper <ca...@continentale.de>.
Hi, I forgot to mention, that we're on Trinidad 1.0.10. When I look into the 
org.apache.myfaces.trinidadinternal.renderkit.core.xhtmlTableRenderer, 
I find this:

  protected Map<String, String> createResourceKeyMap()
  {
    // map the skin resource keys that are used in components used
    // by the table renderer to table keys.
    // This way the table can be customized separately from other
    // components that it uses within it. For example, we can customize
    // af_table.DISCLOSED translation key
    // separately from af_showDetail.DISCLOSED.
    Map<String, String> map = new HashMap<String, String>(6);
    map.put("af_showDetail.DISCLOSED",
            "af_table.DISCLOSED");
    map.put("af_showDetail.UNDISCLOSED",
            "af_table.UNDISCLOSED");
    map.put("af_showDetail.DISCLOSED_TIP",
            "af_table.DISCLOSED_TIP");
    map.put("af_showDetail.UNDISCLOSED_TIP",
            "af_table.UNDISCLOSED_TIP");

    // ... more map entries to follow, but not hard coded as above
    // but via SkinSelecors, like this:
    //    map.put(SkinSelectors.AF_SHOW_DETAIL_DISCLOSED_ICON_NAME,
    //       SkinSelectors.AF_TABLE_SD_DISCLOSED_ICON_NAME);
    //     ...

  }

The original inline comment explicitly says, that the key
"af_table.DISCLOSED"
(table mit facet="detailStamp"), could be configured separately from
af_showDetail.DISCLOSED (showDetail) - only that it doesn't work, at least
not for me.

One thought, though. Would't the hardcoded skelektors (first 4 map entries
here) in this code
be a problem when "stylesheet compression" is turned on (in the web.xml via
	<context-param>
	
<param-name>org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION</param-name>
		<param-value>true</param-value>
	</context-param>
)?

Cheers, Carsten


Carsten Pieper wrote:
> 
> Hello,
> 
> we'd like to use tr:table with facet "detailStamp" but are not
> particularly happy with the
> default texts that come with it. In the CoreBundle.xrts (or, in our case,
> the CoreBundle_de.xrts)
> you find entries with the following keys:
> 
> af_table.DISCLOSED
> af_table.UNDISCLOSED
> af_table.DISCLOSED_TIP
> af_table.UNDISCLOSED_TIP
> 
> By overwriting these in our local Trinidad build, I thought to change the
> texts for our
> szenario but it didn't work out. In fact, the "normal" showDetail entries
> 
> af_showDetailHeader.DISCLOSED
> af_showDetailHeader.UNDISCLOSED
> af_showDetailHeader.DISCLOSED_TIP
> af_showDetailHeader.UNDISCLOSED_TIP
> 
> seem to be used for facet detailStamp, too... :-O
> 
> Any ideas welcome, thanks,
> Carsten
> 
> PS Asked this same question on the users' forum, but (as no one answered) 
> wondered if it wouldn't fit better in here...
> 

-- 
View this message in context: http://www.nabble.com/-TRINIDAD--Configure-texts-for-detailStamp-facet-in-tr%3Atable-tp25382677p25399599.html
Sent from the My Faces - Dev mailing list archive at Nabble.com.