[GitHub] [pulsar] jerrypeng commented on a change in pull request #6752: Support different docker images in Kubernetes runtime of Pulsar Functions

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #6752:
URL: https://github.com/apache/pulsar/pull/6752#discussion_r454819720



##########
File path: conf/functions_worker.yml
##########
@@ -125,6 +125,15 @@ functionRuntimeFactoryConfigs:
 #  jobNamespace:
 #  # the docker image to run function instance. by default it is `apachepulsar/pulsar`
 #  pulsarDockerImageName:
+#  # the docker image to run java function instance, we will uses `pulsarDockerImageName` to run function instance

Review comment:
       If the eventual goal is to make language runtimes pluggable, can we organize this into a map, something like:
   
   `
   functionDockerImages:
     JAVA: apache/pulsar:java
     PYTHON: apache/pulsar:python
     FOO: apache/pulsar:foo
     DEFAULT: apache/pulsar:default
   `
   
   Since language runtimes will be pluggable it doesn't make sense to have concrete configs for a specific language.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org