You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/09 03:46:28 UTC

[GitHub] [dubbo-go-samples] LaurenceLiZhixin opened a new pull request #21: fix: change grpc and sentinel version

LaurenceLiZhixin opened a new pull request #21:
URL: https://github.com/apache/dubbo-go-samples/pull/21


   change grpc versin to 1.26.0
   change sentinal version to 0.6.2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on pull request #21: fix: change grpc and sentinel version

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #21:
URL: https://github.com/apache/dubbo-go-samples/pull/21#issuecomment-743950357


   fixed cicd!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-samples] AlexStocks merged pull request #21: fix: change grpc and sentinel version

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #21:
URL: https://github.com/apache/dubbo-go-samples/pull/21


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #21: fix: change grpc and sentinel version

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #21:
URL: https://github.com/apache/dubbo-go-samples/pull/21#discussion_r541846013



##########
File path: go.mod
##########
@@ -15,8 +17,9 @@ require (
 	github.com/stretchr/testify v1.6.1
 	github.com/uber/jaeger-client-go v2.22.1+incompatible
 	github.com/uber/jaeger-lib v2.2.0+incompatible // indirect
-	google.golang.org/grpc v1.27.0
-	google.golang.org/protobuf v1.25.0 // indirect
+	google.golang.org/grpc v1.26.0
 )
 
 go 1.13
+
+replace github.com/apache/dubbo-go v1.5.2-0.20201205063214-68ff8be79d6d => ../../../dubbo-go

Review comment:
       fixed
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #21: fix: change grpc and sentinel version

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #21:
URL: https://github.com/apache/dubbo-go-samples/pull/21#discussion_r541816010



##########
File path: go.mod
##########
@@ -15,8 +17,9 @@ require (
 	github.com/stretchr/testify v1.6.1
 	github.com/uber/jaeger-client-go v2.22.1+incompatible
 	github.com/uber/jaeger-lib v2.2.0+incompatible // indirect
-	google.golang.org/grpc v1.27.0
-	google.golang.org/protobuf v1.25.0 // indirect
+	google.golang.org/grpc v1.26.0
 )
 
 go 1.13
+
+replace github.com/apache/dubbo-go v1.5.2-0.20201205063214-68ff8be79d6d => ../../../dubbo-go

Review comment:
       r u kidding me?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org