You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/01 04:06:26 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #38856: [SPARK-41314][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_1094`
LuciferYang opened a new pull request, #38856:
URL: https://github.com/apache/spark/pull/38856
### What changes were proposed in this pull request?
This pr aims to rename error class `_LEGACY_ERROR_TEMP_1094` to `INVALID_SCHEMA.NON_STRUCT_TYPE`.
### Why are the changes needed?
Proper names of error classes to improve user experience with Spark SQL.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Add new tests to check `INVALID_SCHEMA.NON_STRUCT_TYPE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38856: [SPARK-41314][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_1094`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38856: [SPARK-41314][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_1094`
URL: https://github.com/apache/spark/pull/38856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38856: [SPARK-41314][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_1094`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38856:
URL: https://github.com/apache/spark/pull/38856#issuecomment-1333421411
thanks @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38856: [SPARK-41314][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_1094`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38856:
URL: https://github.com/apache/spark/pull/38856#issuecomment-1333143698
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38856: [SPARK-41314][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_1094`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38856:
URL: https://github.com/apache/spark/pull/38856#issuecomment-1333419239
+1, LGTM. Merging to master.
Thank you, @LuciferYang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org