You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/08 14:42:23 UTC

[GitHub] [skywalking] zjutkz commented on issue #8091: [Bug] AsyncHttpClient NoSuchMethodError

zjutkz commented on issue #8091:
URL: https://github.com/apache/skywalking/issues/8091#issuecomment-963227892


   @wu-sheng 
   The root cause of this problem is Skywalking changes the arguments of origin method like this:
   `allArguments[1] = new AsyncHandlerWrapper((AsyncHandler) allArguments[1], span);`
   This is a very dangerous action because we cannot predict how the methods of these components will change in the higher version.And I found a lot of similar codes in Skywalking's Java plugin such as rabbitmq、kafka、grpc.
   This leads me to spend a lot of time to do version compatibility testing, so may I ask what was the original intention of doing this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org