You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by jiangxiang89 <gi...@git.apache.org> on 2018/03/13 04:52:56 UTC

[GitHub] incubator-weex pull request #1067: * [android] allow debug in release versio...

GitHub user jiangxiang89 opened a pull request:

    https://github.com/apache/incubator-weex/pull/1067

    * [android] allow debug in release version

    First of all, thank you for your contribution! 
    
    Please makes sure that these checkboxes are checked before submitting your PR, thank you!
    
    <!-- 
    How to use github markdown?
    ### checkable example
    - [x] checked
    - [ ] not checked
    More github Markdown info to see https://guides.github.com/features/mastering-markdown/
    -->
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [ ] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jiangxiangalibaba/incubator-weex feature-enable-debug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1067
    
----
commit e64a1a04d22e3d662d4fe5c463be2bf3b6b2bafb
Author: jiangxiang.jx <ji...@...>
Date:   2018-03-13T04:47:07Z

    * [android] allow debug in release version

----


---

[GitHub] incubator-weex issue #1067: * [android] allow debug in release version

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1067
  
    
    <!--
      0 failure: 
      1 warning:  No Changelog chan...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex issue #1067: * [android] allow debug in release version

Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:

    https://github.com/apache/incubator-weex/pull/1067
  
    hi  @jiangxiang89  thanks for your contribution, please follow the development process
    http://weex.apache.org/development-process.html
    
    thanks 


---

[GitHub] incubator-weex pull request #1067: * [android] allow debug in release versio...

Posted by jiangxiang89 <gi...@git.apache.org>.
Github user jiangxiang89 closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1067


---