You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/16 19:13:27 UTC
[GitHub] [avro] martin-g opened a new pull request #1551: AVRO-3405: Add API to write/read user metadata in .avro file
martin-g opened a new pull request #1551:
URL: https://github.com/apache/avro/pull/1551
### Jira
- [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3405
### Tests
- [X] My PR adds new unit tests
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Rustdoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1551: AVRO-3405: Add API to write/read user metadata in .avro file
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1551:
URL: https://github.com/apache/avro/pull/1551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1551: AVRO-3405: Add API to write/read user metadata in .avro file
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1551:
URL: https://github.com/apache/avro/pull/1551#issuecomment-1042714043
All done!
Please review!
> We prefer the approach taken by `avrow` where `.set_metadata()` is a Builder method and therefore does not require we declare the Writer as `mut`
I've added support for this. But I don't see how useful an immutable Writer could be - you cannot add records/datum to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1551: AVRO-3405: Add API to write/read user metadata in .avro file
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1551:
URL: https://github.com/apache/avro/pull/1551#issuecomment-1043406345
Thanks for the help, @kvc-code !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org