You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/16 17:56:47 UTC
[GitHub] [spark] MaxGekk opened a new pull request #34925: [WIP][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
MaxGekk opened a new pull request #34925:
URL: https://github.com/apache/spark/pull/34925
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Current mode `ECB` is not semantically secure, see [Why shouldn't I use ECB encryption?](https://crypto.stackexchange.com/questions/20941/why-shouldnt-i-use-ecb-encryption).
### Does this PR introduce _any_ user-facing change?
No. Since the `aes_encrypt()`/`aes_decrypt()` functions haven't been released yet, we can change the default mode to more secure one `GCM`.
### How was this patch tested?
By running the affected test suites:
```
$ build/sbt "sql/testOnly *ExpressionsSchemaSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996169081
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50767/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996152251
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50767/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996271938
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146295/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996169081
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50767/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34925: [WIP][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996069345
**[Test build #146295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146295/testReport)** for PR 34925 at commit [`3e10ff3`](https://github.com/apache/spark/commit/3e10ff340c7b5678a0f615ad3eb6dd8e465998e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996362675
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34925:
URL: https://github.com/apache/spark/pull/34925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34925: [WIP][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996104272
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50767/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996271938
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146295/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996260681
**[Test build #146295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146295/testReport)** for PR 34925 at commit [`3e10ff3`](https://github.com/apache/spark/commit/3e10ff340c7b5678a0f615ad3eb6dd8e465998e7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34925: [SPARK-37666][SQL] Set `GCM` as the default mode in `aes_encrypt()`/`aes_decrypt()`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34925:
URL: https://github.com/apache/spark/pull/34925#issuecomment-996069345
**[Test build #146295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146295/testReport)** for PR 34925 at commit [`3e10ff3`](https://github.com/apache/spark/commit/3e10ff340c7b5678a0f615ad3eb6dd8e465998e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org