You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by pi...@apache.org on 2021/08/30 18:33:31 UTC
[submarine] branch master updated: SUBMARINE-993.
NullPointerException could be thrown in MLJobConverter.java
This is an automated email from the ASF dual-hosted git repository.
pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 04c1c93 SUBMARINE-993. NullPointerException could be thrown in MLJobConverter.java
04c1c93 is described below
commit 04c1c931a785e24b02acda5bbf49aaaca20dcd28
Author: 0yukali0 <a0...@gmail.com>
AuthorDate: Sun Aug 29 21:42:57 2021 +0800
SUBMARINE-993. NullPointerException could be thrown in MLJobConverter.java
### What is this PR for?
Avoid NullPointerException problem in MLJobConverter.java
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-993
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: 0yukali0 <a0...@gmail.com>
Signed-off-by: Kevin <pi...@apache.org>
Closes #730 from 0yukali0/SUBMARINE-993 and squashes the following commits:
e7655a11 [0yukali0] NullPointerException could be thrown in MLJobConverter.java
---
.../org/apache/submarine/server/submitter/k8s/util/MLJobConverter.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/util/MLJobConverter.java b/submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/util/MLJobConverter.java
index 44a4c17..93f9deb 100644
--- a/submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/util/MLJobConverter.java
+++ b/submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/util/MLJobConverter.java
@@ -20,7 +20,6 @@
package org.apache.submarine.server.submitter.k8s.util;
import java.util.List;
-
import io.kubernetes.client.models.V1DeleteOptions;
import io.kubernetes.client.models.V1DeleteOptionsBuilder;
import io.kubernetes.client.models.V1JobCondition;
@@ -66,7 +65,7 @@ public class MLJobConverter {
}
dateTime = status.getCompletionTime();
- if (dateTime != null) {
+ if (conditions != null && dateTime != null) {
experiment.setFinishedTime(dateTime.toString());
if ("Succeeded".equalsIgnoreCase(conditions.get(conditions.size() - 1).getType())) {
experiment.setStatus(Experiment.Status.STATUS_SUCCEEDED.getValue());
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org