You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/01/31 00:59:43 UTC
Review Request: SQOOP-855 pg_bulkload: NullPointerException will be thrown
if user specified invalid path the binary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9168/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
The NPE was caused by calling cleanup from catch block in setup method. I've added conditions to check each variable before closing.
This addresses bug SQOOP-855.
https://issues.apache.org/jira/browse/SQOOP-855
Diffs
-----
src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java 14d064a51725b23fe79990df8288554b4a22556a
Diff: https://reviews.apache.org/r/9168/diff/
Testing
-------
Tested on real cluster.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-855 pg_bulkload: NullPointerException will be
thrown if user specified invalid path the binary
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9168/#review15909
-----------------------------------------------------------
Ship it!
Ship It!
- Cheolsoo Park
On Jan. 30, 2013, 11:59 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9168/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 11:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> The NPE was caused by calling cleanup from catch block in setup method. I've added conditions to check each variable before closing.
>
>
> This addresses bug SQOOP-855.
> https://issues.apache.org/jira/browse/SQOOP-855
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java 14d064a51725b23fe79990df8288554b4a22556a
>
> Diff: https://reviews.apache.org/r/9168/diff/
>
>
> Testing
> -------
>
> Tested on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>