You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by st...@apache.org on 2015/03/31 19:58:16 UTC

[1/3] cordova-plugin-inappbrowser git commit: CB-8432 Correct styles for browser wrapper to display it correctly on some pages

Repository: cordova-plugin-inappbrowser
Updated Branches:
  refs/heads/old-ID ed1227f61 -> 805d43d61


CB-8432 Correct styles for browser wrapper to display it correctly on some pages

* Force z-order for wrapper to show it on top of the whole page
* Apply CSS reset rules to browser wrapper
* Disable parent window scrollbars when browser is shown


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/57f94267
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/57f94267
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/57f94267

Branch: refs/heads/old-ID
Commit: 57f942670c84412b61bc05dd67c5b505edb4b67d
Parents: ed1227f
Author: Vladimir Kotikov <v-...@microsoft.com>
Authored: Thu Feb 5 17:14:41 2015 +0300
Committer: Vladimir Kotikov <v-...@microsoft.com>
Committed: Tue Mar 17 14:18:04 2015 +0300

----------------------------------------------------------------------
 src/windows/InAppBrowserProxy.js | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/57f94267/src/windows/InAppBrowserProxy.js
----------------------------------------------------------------------
diff --git a/src/windows/InAppBrowserProxy.js b/src/windows/InAppBrowserProxy.js
index 07fa79e..da5eb82 100644
--- a/src/windows/InAppBrowserProxy.js
+++ b/src/windows/InAppBrowserProxy.js
@@ -110,20 +110,30 @@ var IAB = {
             // "_blank" or anything else
             if (!browserWrap) {
                 browserWrap = document.createElement("div");
-                browserWrap.style.position = "absolute";
-                browserWrap.style.borderWidth = "40px";
-                browserWrap.style.width = "calc(100% - 80px)";
-                browserWrap.style.height = "calc(100% - 80px)";
-                browserWrap.style.borderStyle = "solid";
-                browserWrap.style.borderColor = "rgba(0,0,0,0.25)";
+                // First reset all styles for inappbrowser wrapper element
+                browserWrap.style.cssText = "margin:0;padding:0;border:0;outline:0;font-size:100%;vertical-align:baseline;background: 0 0;";
+                browserWrap.style.position = "fixed";
+                browserWrap.style.top = "0px";
+                browserWrap.style.left = "0px";
+                browserWrap.style.width = "100%";
+                browserWrap.style.height = "100%";
+                browserWrap.style.zIndex = 9999;
+                browserWrap.style.border = "40px solid rgba(0,0,0,0.25)";
+
+                // Save body overflow style to be able to reset it back later
+                var bodyOverflow = document.body.style.msOverflowStyle;
 
                 browserWrap.onclick = function () {
                     setTimeout(function () {
+                        // Reset body overflow style to initial value
+                        document.body.style.msOverflowStyle = bodyOverflow;
                         IAB.close(win);
                     }, 0);
                 };
 
                 document.body.appendChild(browserWrap);
+                // Hide scrollbars for the whole body while inappbrowser's window is open
+                document.body.style.msOverflowStyle = "none";
             }
 
             if (features.indexOf("hidden=yes") !== -1) {
@@ -131,6 +141,11 @@ var IAB = {
             }
 
             popup = document.createElement(isWebViewAvailable ? "x-ms-webview" : "iframe");
+            if (popup instanceof HTMLIFrameElement) {
+                // For iframe we need to override bacground color of parent element here
+                // otherwise pages without background color set will have transparent background
+                popup.style.backgroundColor = "white";
+            }
             popup.style.borderWidth = "0px";
             popup.style.width = "100%";
 
@@ -257,4 +272,4 @@ var IAB = {
 
 module.exports = IAB;
 
-require("cordova/exec/proxy").add("InAppBrowser", module.exports);
\ No newline at end of file
+require("cordova/exec/proxy").add("InAppBrowser", module.exports);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[3/3] cordova-plugin-inappbrowser git commit: CB-8653 updated translated docs to use new id

Posted by st...@apache.org.
CB-8653 updated translated docs to use new id


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/805d43d6
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/805d43d6
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/805d43d6

Branch: refs/heads/old-ID
Commit: 805d43d61d673d55bbc6c8373e76c1e6a27885fc
Parents: 9901d62
Author: Steve Gill <st...@gmail.com>
Authored: Tue Mar 31 10:53:32 2015 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Tue Mar 31 10:53:32 2015 -0700

----------------------------------------------------------------------
 doc/de/index.md | 2 +-
 doc/es/index.md | 2 +-
 doc/fr/index.md | 2 +-
 doc/it/index.md | 2 +-
 doc/ja/index.md | 2 +-
 doc/ko/index.md | 2 +-
 doc/pl/index.md | 2 +-
 doc/ru/index.md | 2 +-
 doc/zh/index.md | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/de/index.md
----------------------------------------------------------------------
diff --git a/doc/de/index.md b/doc/de/index.md
index b610b77..e0598f7 100644
--- a/doc/de/index.md
+++ b/doc/de/index.md
@@ -354,4 +354,4 @@ Bei einem Aufruf von `cordova.InAppBrowser.open` zurückgegebene Objekt..
     var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });

http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/es/index.md
----------------------------------------------------------------------
diff --git a/doc/es/index.md b/doc/es/index.md
index 2eec187..6411a8a 100644
--- a/doc/es/index.md
+++ b/doc/es/index.md
@@ -354,4 +354,4 @@ El objeto devuelto desde una llamada a `cordova.InAppBrowser.open`.
     var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });

http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/fr/index.md
----------------------------------------------------------------------
diff --git a/doc/fr/index.md b/doc/fr/index.md
index 214e358..aaac719 100644
--- a/doc/fr/index.md
+++ b/doc/fr/index.md
@@ -354,4 +354,4 @@ L'objet retourné par un appel à `cordova.InAppBrowser.open`.
     var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });

http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/it/index.md
----------------------------------------------------------------------
diff --git a/doc/it/index.md b/doc/it/index.md
index 9cb7340..2812214 100644
--- a/doc/it/index.md
+++ b/doc/it/index.md
@@ -354,4 +354,4 @@ L'oggetto restituito da una chiamata a `di cordova.InAppBrowser.open`.
     var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });

http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/ja/index.md
----------------------------------------------------------------------
diff --git a/doc/ja/index.md b/doc/ja/index.md
index ca09128..557e6b0 100644
--- a/doc/ja/index.md
+++ b/doc/ja/index.md
@@ -354,4 +354,4 @@ InAppBrowser を通過するアプリですべてのページの読み込みを
     var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });

http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/ko/index.md
----------------------------------------------------------------------
diff --git a/doc/ko/index.md b/doc/ko/index.md
index 674af7a..4051ca0 100644
--- a/doc/ko/index.md
+++ b/doc/ko/index.md
@@ -354,4 +354,4 @@ InAppBrowser를 통해가 서 당신의 애플 리 케이 션에서 모든 페
     var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });

http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/pl/index.md
----------------------------------------------------------------------
diff --git a/doc/pl/index.md b/doc/pl/index.md
index 8085630..9344329 100644
--- a/doc/pl/index.md
+++ b/doc/pl/index.md
@@ -354,4 +354,4 @@ Obiekt zwrócony z wywołania `cordova.InAppBrowser.open`.
     var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });

http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/ru/index.md
----------------------------------------------------------------------
diff --git a/doc/ru/index.md b/doc/ru/index.md
index 3ca2ef8..8bba1ce 100644
--- a/doc/ru/index.md
+++ b/doc/ru/index.md
@@ -327,4 +327,4 @@
     var ref = window.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });

http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/805d43d6/doc/zh/index.md
----------------------------------------------------------------------
diff --git a/doc/zh/index.md b/doc/zh/index.md
index 3798b83..ce10183 100644
--- a/doc/zh/index.md
+++ b/doc/zh/index.md
@@ -354,4 +354,4 @@ InAppBrowser 預設情況下它自己的 GUI 控制項為使用者提供 (後
     var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
     ref.addEventListener('loadstop', function() {
         ref.insertCSS({file: "mystyles.css"});
-    });
\ No newline at end of file
+    });


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[2/3] cordova-plugin-inappbrowser git commit: Use TRAVIS_BUILD_DIR, install paramedic by npm

Posted by st...@apache.org.
Use TRAVIS_BUILD_DIR, install paramedic by npm


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/9901d622
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/9901d622
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/9901d622

Branch: refs/heads/old-ID
Commit: 9901d62248e9309d2adc3736bc470e69790fe6a6
Parents: 57f9426
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Tue Mar 24 23:34:39 2015 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Tue Mar 24 23:34:39 2015 -0700

----------------------------------------------------------------------
 .travis.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/9901d622/.travis.yml
----------------------------------------------------------------------
diff --git a/.travis.yml b/.travis.yml
index 6da1b1f..fa7ae7d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -6,8 +6,8 @@ node_js:
 install:
   - echo -e "Host github.com\n\tStrictHostKeyChecking no\n" >> ~/.ssh/config 
   - cd ..
-  - npm install -g purplecabbage/cordova-paramedic
+  - npm install -g cordova-paramedic
   - npm install -g cordova
   - npm install -g ios-sim
 script:
-  - cordova-paramedic --platform ios --plugin ../cordova-plugin-inappbrowser
+  - cordova-paramedic --platform ios --plugin ${TRAVIS_BUILD_DIR}


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org