[GitHub] [accumulo] ctubbsii commented on a change in pull request #1166: Fix #886 Deprecate general.dynamic.classpaths

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1166: Fix #886 Deprecate general.dynamic.classpaths
URL: https://github.com/apache/accumulo/pull/1166#discussion_r286237913
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -904,6 +900,13 @@
           + " the jar starting in the first location to the last. Supports full regex"
           + " on filename alone."),
   @Deprecated
+  GENERAL_DYNAMIC_CLASSPATHS(AccumuloVFSClassLoader.DYNAMIC_CLASSPATH_PROPERTY_NAME,
+      AccumuloVFSClassLoader.DEFAULT_DYNAMIC_CLASSPATH_VALUE, PropertyType.STRING,
+      "This property is deprecated since 2.0.0. "
+          + "A similar result can be acheived by using a custom class loader and configuring "
 
 Review comment:
   My description of why it was deprecated is probably not a good substitute for the previous description of what it actually does. It should keep the original wording, prefixed with the "This property is deprecated since 2.0.0. " sentence. If additional explanation is needed after, perhaps we can append something like: "Built-in dynamic class loading will be removed in a future version. If you need this, consider overriding the Java system class loader with one that has this feature (https://docs.oracle.com/javase/8/docs/api/java/lang/ClassLoader.html#getSystemClassLoader--)."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services