You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by gn...@apache.org on 2012/05/23 10:16:11 UTC

svn commit: r1341777 - /karaf/branches/karaf-2.3.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java

Author: gnodet
Date: Wed May 23 08:16:11 2012
New Revision: 1341777

URL: http://svn.apache.org/viewvc?rev=1341777&view=rev
Log:
[KARAF-1496] Bad login when using sufficient modules but when the first fail

Modified:
    karaf/branches/karaf-2.3.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java

Modified: karaf/branches/karaf-2.3.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.3.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java?rev=1341777&r1=1341776&r2=1341777&view=diff
==============================================================================
--- karaf/branches/karaf-2.3.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java (original)
+++ karaf/branches/karaf-2.3.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java Wed May 23 08:16:11 2012
@@ -55,6 +55,9 @@ public abstract class AbstractKarafLogin
     private EncryptionSupport encryptionSupport;
 
     public boolean commit() throws LoginException {
+        if (principals.isEmpty()) {
+            return false;
+        }
         RolePolicy policy = RolePolicy.getPolicy(rolePolicy);
         if (policy != null && roleDiscriminator != null) {
             policy.handleRoles(subject, principals, roleDiscriminator);