[GitHub] betodealmeida closed pull request #5766: Disable input when IS (NOT) NULL selected

[GitBox <gi...@apache.org>]

betodealmeida closed pull request #5766: Disable input when IS (NOT) NULL selected
URL: https://github.com/apache/incubator-superset/pull/5766
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
index 94535cdea7..6c670b6d7c 100644
--- a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
+++ b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
@@ -283,6 +283,7 @@ export default class AdhocFilterEditPopoverSimpleTabContent extends React.Compon
                 value={adhocFilter.comparator || ''}
                 className="form-control input-sm"
                 placeholder={t('Filter value')}
+                disabled={adhocFilter.operator === 'IS NOT NULL' || adhocFilter.operator === 'IS NULL'}
               />
           }
         </FormGroup>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org