[GitHub] eiri commented on issue #1273: Adopt fake_db to PSE changes

[GitBox <gi...@apache.org>]

eiri commented on issue #1273: Adopt fake_db to PSE changes
URL: https://github.com/apache/couchdb/pull/1273#issuecomment-380442650
 
 
   @iilyak Amusingly, now when `mem3_shards` tests are actually running this exposed what appears to be a race in `mem3` test suite. I'm getting the suite failing on me about once in five runs with:
   ```
    mem3_shards:679: t_cache_insert_ignores_stale_update_and_kills_worker...ok
     Test mem3_shards changes listener
       mem3_shards:754: should_kill_changes_listener_on_shutdown...*failed*
   in function mem3_shards:'-should_kill_changes_listener_on_shutdown/1-fun-1-'/1 (src/mem3_shards.erl, line 757)
   in call from mem3_shards:'-should_kill_changes_listener_on_shutdown/1-fun-4-'/1 (src/mem3_shards.erl, line 757)
   **error:{assertion_failed,[{module,mem3_shards},
                      {line,757},
                      {expression,"is_process_alive ( ChangesPid )"},
                      {expected,true},
                      {value,false}]}
   
   
       [done in 0.003 s]
     [done in 1.471 s]
   ```
   
   Going to fix that before merging, don't want to make our pipeline more finicky, than it is already. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services