You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2003/06/16 06:29:40 UTC
Re: svn commit: rev 6242 - trunk/subversion/libsvn_repos
On Mon, 2003-06-16 at 01:10, cmpilato@tigris.org wrote:
> -#if 1
> - /*** Temporary kludge for compatibility with older ra_dav clients
> - while they learn that it's okay to have an editor drive with no
> - open_root(). This should be sometime after the 0.24 release
> - (See issue #1159). ***/
> - if (! root_baton)
> - SVN_ERR (editor->open_root (edit_baton, rootrev, pool, &root_baton));
> -#endif
> -
If we can have an editor drive with no open_root (which I'm fine with),
the following comment from svn_delta.h may want to be reworded:
* At the start of traversal, the consumer provides @a edit_baton, a
* baton global to the entire delta edit. If there is a target
* revision that needs to be set for this operation, the producer
* should called the @c set_target_revision function at this point.
* Next, the producer should pass this @a edit_baton to the @c open_root
* function, to get a baton representing root of the tree being
* edited.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 6242 - trunk/subversion/libsvn_repos
Posted by cm...@collab.net.
Greg Hudson <gh...@MIT.EDU> writes:
> On Mon, 2003-06-16 at 01:10, cmpilato@tigris.org wrote:
> > -#if 1
> > - /*** Temporary kludge for compatibility with older ra_dav clients
> > - while they learn that it's okay to have an editor drive with no
> > - open_root(). This should be sometime after the 0.24 release
> > - (See issue #1159). ***/
> > - if (! root_baton)
> > - SVN_ERR (editor->open_root (edit_baton, rootrev, pool, &root_baton));
> > -#endif
> > -
>
> If we can have an editor drive with no open_root (which I'm fine with),
> the following comment from svn_delta.h may want to be reworded:
>
> * At the start of traversal, the consumer provides @a edit_baton, a
> * baton global to the entire delta edit. If there is a target
> * revision that needs to be set for this operation, the producer
> * should called the @c set_target_revision function at this point.
> * Next, the producer should pass this @a edit_baton to the @c open_root
> * function, to get a baton representing root of the tree being
> * edited.
Quite right. Thanks for noticing that! Will change (after a string
of other changes ... working copy now has 3 changesets in it).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org