You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/05/26 22:51:45 UTC
[jira] Created: (CASSANDRA-199) Row.columnFamilies_ is initialized
to Hashtable in one place, HashMap in another
Row.columnFamilies_ is initialized to Hashtable in one place, HashMap in another
--------------------------------------------------------------------------------
Key: CASSANDRA-199
URL: https://issues.apache.org/jira/browse/CASSANDRA-199
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
which is right?
note that this behavior dates to the initial import into apache svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-199) Row.columnFamilies_ is
initialized to Hashtable in one place, HashMap in another
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721446#action_12721446 ]
Sandeep Tata commented on CASSANDRA-199:
----------------------------------------
+1
Per IRC, we should also clean up misleading comments in Table.load
> Row.columnFamilies_ is initialized to Hashtable in one place, HashMap in another
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-199
> URL: https://issues.apache.org/jira/browse/CASSANDRA-199
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 199.patch
>
>
> which is right?
> note that this behavior dates to the initial import into apache svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-199) Row.columnFamilies_ is initialized
to Hashtable in one place, HashMap in another
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-199:
-------------------------------------
Fix Version/s: 0.4
Assignee: Jonathan Ellis
> Row.columnFamilies_ is initialized to Hashtable in one place, HashMap in another
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-199
> URL: https://issues.apache.org/jira/browse/CASSANDRA-199
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
>
> which is right?
> note that this behavior dates to the initial import into apache svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-199) Row.columnFamilies_ is
initialized to Hashtable in one place, HashMap in another
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721765#action_12721765 ]
Hudson commented on CASSANDRA-199:
----------------------------------
Integrated in Cassandra #113 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/113/])
minor cleanup of Row code. patch by jbellis; reviewed by Sandeep Tata for
> Row.columnFamilies_ is initialized to Hashtable in one place, HashMap in another
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-199
> URL: https://issues.apache.org/jira/browse/CASSANDRA-199
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 199.patch
>
>
> which is right?
> note that this behavior dates to the initial import into apache svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-199) Row.columnFamilies_ is initialized
to Hashtable in one place, HashMap in another
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-199:
-------------------------------------
Attachment: 199.patch
I can't find any places Row is used concurrently in multiple threads, so HashMap seems like the Right choice.
(Patch also does other minor cleanup to Row-related code that I ran across while looking.)
> Row.columnFamilies_ is initialized to Hashtable in one place, HashMap in another
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-199
> URL: https://issues.apache.org/jira/browse/CASSANDRA-199
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 199.patch
>
>
> which is right?
> note that this behavior dates to the initial import into apache svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-199) Row.columnFamilies_ is
initialized to Hashtable in one place, HashMap in another
Posted by "Edward Ribeiro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719271#action_12719271 ]
Edward Ribeiro commented on CASSANDRA-199:
------------------------------------------
I don't think so.
Hashtable is a legacy class and it's advised to use Collections.synchronizedMap(new HashMap()) instead. Furthermore, the only reason to use a synchronized Map is concurrency control (it's the case here?).
+1 to replace Hashtable for HashMap.
> Row.columnFamilies_ is initialized to Hashtable in one place, HashMap in another
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-199
> URL: https://issues.apache.org/jira/browse/CASSANDRA-199
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
>
> which is right?
> note that this behavior dates to the initial import into apache svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-199) Row.columnFamilies_ is initialized
to Hashtable in one place, HashMap in another
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-199:
-------------------------------------
Component/s: Core
> Row.columnFamilies_ is initialized to Hashtable in one place, HashMap in another
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-199
> URL: https://issues.apache.org/jira/browse/CASSANDRA-199
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 199.patch
>
>
> which is right?
> note that this behavior dates to the initial import into apache svn.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.