You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2023/08/07 08:43:54 UTC
[PR] Refactor SegmentLoadDropHandler to fix concurrency bugs (druid)
kfaraz opened a new pull request, #14764:
URL: https://github.com/apache/druid/pull/14764
### Motivation
### Design
### Changes
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Refactor SegmentLoadDropHandler to fix concurrency bugs (druid)
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #14764:
URL: https://github.com/apache/druid/pull/14764#discussion_r1285617778
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java:
##########
@@ -639,273 +539,235 @@
return serverTypeConfig.getServerType().isSegmentServer() || !config.getLocations().isEmpty();
}
- private static class BackgroundSegmentAnnouncer implements AutoCloseable
+ /**
+ * Represents the future result of a single batch of segment load drop requests.
+ */
+ private static class LoadDropBatch extends AbstractFuture<List<DataSegmentChangeResponse>>
{
- private static final EmittingLogger log = new EmittingLogger(BackgroundSegmentAnnouncer.class);
-
- private final int intervalMillis;
- private final DataSegmentAnnouncer announcer;
- private final ScheduledExecutorService exec;
- private final LinkedBlockingQueue<DataSegment> queue;
- private final SettableFuture<Boolean> doneAnnouncing;
-
- private final Object lock = new Object();
-
- private volatile boolean finished = false;
- @Nullable
- private volatile ScheduledFuture startedAnnouncing = null;
- @Nullable
- private volatile ScheduledFuture nextAnnoucement = null;
+ private final List<LoadDropTask> tasks;
- public BackgroundSegmentAnnouncer(
- DataSegmentAnnouncer announcer,
- ScheduledExecutorService exec,
- int intervalMillis
- )
+ LoadDropBatch(List<LoadDropTask> tasks)
{
- this.announcer = announcer;
- this.exec = exec;
- this.intervalMillis = intervalMillis;
- this.queue = new LinkedBlockingQueue<>();
- this.doneAnnouncing = SettableFuture.create();
+ this.tasks = tasks;
}
- public void announceSegment(final DataSegment segment) throws InterruptedException
+ void cancelTaskIfNotIn(List<LoadDropTask> task)
Review Comment:
## Useless parameter
The parameter 'task' is never used.
[Show more details](https://github.com/apache/druid/security/code-scanning/5337)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Refactor SegmentLoadDropHandler to fix concurrency bugs (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14764:
URL: https://github.com/apache/druid/pull/14764#issuecomment-1958433647
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Refactor SegmentLoadDropHandler to fix concurrency bugs (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14764:
URL: https://github.com/apache/druid/pull/14764#issuecomment-2073695067
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org