You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by CMoH <gi...@git.apache.org> on 2017/11/27 16:24:20 UTC
[GitHub] servicemix-bundles pull request #109: Janusgraph OSGi bundle
GitHub user CMoH opened a pull request:
https://github.com/apache/servicemix-bundles/pull/109
Janusgraph OSGi bundle
Add a OSGi bundle for janusgraph-core. The goal is to be able to access janusgraph servers remotely from OSGi environments. I've added an example at https://github.com/CMoH/tinkerpop-osgi-samples on how this bundle is usable to connect to a remote server.
Also added OSGi bundle for gremlin-driver-3.2.6, since it is a dependency of janusgraph-core-0.2.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CMoH/servicemix-bundles janusgraph
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/servicemix-bundles/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit f8d31a8857e342a5de28dde3c46260e74913a8b1
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2017-11-23T20:49:15Z
Create OSGi bundle for gremlin-driver-3.2.6 (shaded)
commit 1558f1a80417629f107c129bef46577aef8f6247
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2017-11-23T20:52:21Z
Create OSGi bundle for janusgraph-core 0.2.0 (shaded)
Depends at runtime on OSGi bundle gremlin-driver-shaded-3.2.6
----
---
[GitHub] servicemix-bundles pull request #109: Janusgraph OSGi bundle
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/servicemix-bundles/pull/109
---
[GitHub] servicemix-bundles pull request #109: Janusgraph OSGi bundle
Posted by jbonofre <gi...@git.apache.org>.
Github user jbonofre commented on a diff in the pull request:
https://github.com/apache/servicemix-bundles/pull/109#discussion_r153473000
--- Diff: gremlin-driver-3.2.6-shaded/pom.xml ---
@@ -0,0 +1,105 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
+ <!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.servicemix.bundles</groupId>
+ <artifactId>bundles-pom</artifactId>
+ <version>13</version>
+ <relativePath>../bundles-pom/pom.xml</relativePath>
+ </parent>
+
+ <groupId>org.apache.servicemix.bundles</groupId>
+ <artifactId>org.apache.servicemix.bundles.gremlin-driver-shaded</artifactId>
--- End diff --
Why `shaded` ? We should simply use `gremlin-driver` IMHO.
---
[GitHub] servicemix-bundles pull request #109: Janusgraph OSGi bundle
Posted by jbonofre <gi...@git.apache.org>.
Github user jbonofre commented on a diff in the pull request:
https://github.com/apache/servicemix-bundles/pull/109#discussion_r153473140
--- Diff: janusgraph-core-0.2.0-shaded/pom.xml ---
@@ -0,0 +1,117 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
+ <!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.servicemix.bundles</groupId>
+ <artifactId>bundles-pom</artifactId>
+ <version>13</version>
+ <relativePath>../bundles-pom/pom.xml</relativePath>
+ </parent>
+
+ <groupId>org.apache.servicemix.bundles</groupId>
+ <artifactId>org.apache.servicemix.bundles.janusgraph-core-shaded</artifactId>
--- End diff --
Same here, why `shaded` ? The `artifactId` is already unique.
---