You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/09/28 13:12:55 UTC
[GitHub] incubator-gearpump pull request #226: [WIP] Don't use window runner for non-...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/226
[WIP] Don't use window runner for non-folding function
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump simplify_dsl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
----
commit 53920da8ebdd9be1f4a194ff3d8ba3e3b6044995
Author: manuzhang <ow...@gmail.com>
Date: 2017-08-01T04:08:46Z
Don't use window runner for non-folding function
----
---
[GitHub] incubator-gearpump issue #226: [GEARPUMP-367] Don't use windowing unnecessar...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/226
R: @huafengw
The failed test `AppMasterSpec` is unrelated to this PR.
---
[GitHub] incubator-gearpump issue #226: [WIP] Don't use window runner for non-folding...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/226
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/226?src=pr&el=h1) Report
> Merging [#226](https://codecov.io/gh/apache/incubator-gearpump/pull/226?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/8aac07b86d4b90e4f5118f3204610d3510f93b02?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `69.69%`.
```diff
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 68.94% 69.01% +0.07%
==========================================
Files 191 191
Lines 6128 6152 +24
Branches 542 533 -9
==========================================
+ Hits 4225 4246 +21
- Misses 1903 1906 +3
```
---
[GitHub] incubator-gearpump pull request #226: [WIP] Don't use window runner for non-...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/226#discussion_r141615634
--- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala ---
@@ -73,6 +73,25 @@ case class AndThen[IN, MIDDLE, OUT](left: WindowRunner[IN, MIDDLE],
}
}
+class DirectWindowRunner[IN, OUT](fnRunner: FunctionRunner[IN, OUT])
--- End diff --
@huafengw I'm a bit stuck for the name here. This is actually not a window runner. Any suggestions ?
---
[GitHub] incubator-gearpump issue #226: [GEARPUMP-367] Don't use windowing unnecessar...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/226
+1
---
[GitHub] incubator-gearpump issue #226: [WIP] Don't use window runner for non-folding...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/226
1. `WindowRunner` => `TimedValueProcessor` which processes `TimestampedValue` and emit `TriggeredOutputs` on trigger
2. Add a subclass `DirectProcessor` which processes `TimestampedValue` with non-folding function (or corresponding `FunctionRunner`
3. Change previous `DefaultWindowRunner` and `WindowRunner`
---
[GitHub] incubator-gearpump pull request #226: [WIP] Don't use window runner for non-...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/226#discussion_r141637090
--- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala ---
@@ -73,6 +73,25 @@ case class AndThen[IN, MIDDLE, OUT](left: WindowRunner[IN, MIDDLE],
}
}
+class DirectWindowRunner[IN, OUT](fnRunner: FunctionRunner[IN, OUT])
--- End diff --
Maybe change `WindowRunner` to a more generic name? Then `DirectWindowRunner` can be a non-window runner.
---
[GitHub] incubator-gearpump pull request #226: [GEARPUMP-367] Don't use windowing unn...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/226
---