You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org> on 2009/04/22 09:32:47 UTC
[jira] Created: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Capacity Scheduler should not check for presence of default queue while starting up.
------------------------------------------------------------------------------------
Key: HADOOP-5718
URL: https://issues.apache.org/jira/browse/HADOOP-5718
Project: Hadoop Core
Issue Type: Bug
Components: contrib/capacity-sched
Reporter: Sreekanth Ramakrishnan
Assignee: Sreekanth Ramakrishnan
Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5718:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.20.1
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed this to trunk and branch 0.20. Thanks, Sreekanth !
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Fix For: 0.20.1
>
> Attachments: HADOOP-5718-1.patch, HADOOP-5718-2.patch, HADOOP-5718-20.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-5718:
-------------------------------------------
Attachment: HADOOP-5718-20.patch
Attaching patch for branch 20.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5718-1.patch, HADOOP-5718-2.patch, HADOOP-5718-20.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705983#action_12705983 ]
Hemanth Yamijala commented on HADOOP-5718:
------------------------------------------
The earlier patch for trunk did not apply to trunk because of commit of HADOOP-5726. However, the patch for branch 0.20 is applying cleanly. I ran ant test-patch on this to make sure it still approves. Capacity scheduler tests also run fine. So, I will commit this patch to both 0.20 and trunk.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5718-1.patch, HADOOP-5718-2.patch, HADOOP-5718-20.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702289#action_12702289 ]
Hemanth Yamijala commented on HADOOP-5718:
------------------------------------------
- The variable 'DEFAULT_QUEUE_NAME' can be removed.
- Maybe unrelated to this patch, but the new raiseStatusChangeEvents should be used in atleast one more test case, testSchedulingInformation. Can you please check this, and other usages of the old raiseStatusChangeEvents method ?
Otherwise, the code changes are fine.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5718-1.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704890#action_12704890 ]
Hadoop QA commented on HADOOP-5718:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406348/HADOOP-5718-2.patch
against trunk revision 770321.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/console
This message is automatically generated.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5718-1.patch, HADOOP-5718-2.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-5718:
-------------------------------------------
Status: Patch Available (was: Open)
Running thro hudson.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5718-1.patch, HADOOP-5718-2.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-5718:
-------------------------------------------
Attachment: HADOOP-5718-2.patch
Attaching patch incorporating Hemanth's comment:
* Add {{raiseStatusChangeEvent(JobQueueManager, QueueName)}} to {{testSchedulingInfo()}}
No other test case needs it because places where {{raiseStatusChangeEvent()}} is being used is with single default queue.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5718-1.patch, HADOOP-5718-2.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-5718:
-------------------------------------------
Attachment: HADOOP-5718-1.patch
A straight forward patch. Attaching the patch removing the check from {{CapacityScheduler}} and added a new test case.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5718-1.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701418#action_12701418 ]
Sreekanth Ramakrishnan commented on HADOOP-5718:
------------------------------------------------
Currently capacity scheduler checks for presence of default queue while starting up, ideally scheduler should not rely on any specific queue to be configured.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5718) Capacity Scheduler should not check
for presence of default queue while starting up.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706148#action_12706148 ]
Hudson commented on HADOOP-5718:
--------------------------------
Integrated in Hadoop-trunk #827 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/827/])
. Remove the check for the default queue in capacity scheduler. Contributed by Sreekanth Ramakrishnan.
> Capacity Scheduler should not check for presence of default queue while starting up.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5718
> URL: https://issues.apache.org/jira/browse/HADOOP-5718
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Fix For: 0.20.1
>
> Attachments: HADOOP-5718-1.patch, HADOOP-5718-2.patch, HADOOP-5718-20.patch
>
>
> Remove the check for default queue while capacity scheduler initializes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.