You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2011/01/07 07:30:38 UTC
svn commit: r1056198 - in
/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues:
AbstractIssuesReportGenerator.java IssuesReportGenerator.java
Author: dennisl
Date: Fri Jan 7 06:30:37 2011
New Revision: 1056198
URL: http://svn.apache.org/viewvc?rev=1056198&view=rev
Log:
o Refactoring: Make use of the new abstract super class.
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/AbstractIssuesReportGenerator.java
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java
Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/AbstractIssuesReportGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/AbstractIssuesReportGenerator.java?rev=1056198&r1=1056197&r2=1056198&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/AbstractIssuesReportGenerator.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/AbstractIssuesReportGenerator.java Fri Jan 7 06:30:37 2011
@@ -60,7 +60,14 @@ public abstract class AbstractIssuesRepo
{
sink.tableCell();
- sink.text( text );
+ if ( text != null )
+ {
+ sink.text( text );
+ }
+ else
+ {
+ sink.rawText( " " );
+ }
sink.tableCell_();
}
Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java?rev=1056198&r1=1056197&r2=1056198&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java Fri Jan 7 06:30:37 2011
@@ -23,7 +23,6 @@ import org.apache.maven.doxia.sink.Sink;
import org.apache.maven.reporting.MavenReportException;
import java.text.DateFormat;
-import java.text.SimpleDateFormat;
import java.util.List;
import java.util.Locale;
import java.util.ResourceBundle;
@@ -36,7 +35,7 @@ import java.util.ResourceBundle;
* @version $Id$
* @since 2.4
*/
-public class IssuesReportGenerator
+public class IssuesReportGenerator extends AbstractIssuesReportGenerator
{
/**
* Fallback value that is used if date field are not available.
@@ -270,68 +269,4 @@ public class IssuesReportGenerator
sink.table_();
}
-
- private void sinkBeginReport( Sink sink, ResourceBundle bundle )
- {
- sink.head();
-
- String title = null;
- title = bundle.getString( "report.issues.header" );
- sink.title();
- sink.text( title );
- sink.title_();
-
- sink.head_();
-
- sink.body();
-
- sink.section1();
-
- sinkSectionTitle1( sink, title );
- }
-
- private void sinkCell( Sink sink, String text )
- {
- sink.tableCell();
-
- if ( text != null )
- {
- sink.text( text );
- }
- else
- {
- sink.rawText( " " );
- }
-
- sink.tableCell_();
- }
-
- private void sinkEndReport( Sink sink )
- {
- sink.section1_();
-
- sink.body_();
-
- sink.flush();
-
- sink.close();
- }
-
- private void sinkHeader( Sink sink, String header )
- {
- sink.tableHeaderCell();
-
- sink.text( header );
-
- sink.tableHeaderCell_();
- }
-
- private void sinkSectionTitle1( Sink sink, String text )
- {
- sink.sectionTitle1();
-
- sink.text( text );
-
- sink.sectionTitle1_();
- }
}