You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by "Ruben D. Porras" <ru...@w2en.com> on 2017/06/20 20:47:04 UTC
Re: Review Request 59883: Support specifying a custom
ShiroCredentialsMatcher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/
-----------------------------------------------------------
(Updated June 20, 2017, 10:47 p.m.)
Review request for Aurora.
Summary (updated)
-----------------
Support specifying a custom ShiroCredentialsMatcher
Repository: aurora
Description
-------
Includes:
- Adding eclipse generated files to .gitignore
- Support specifying a custom ShiroCredentialsMatcher
Diffs
-----
.gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
Diff: https://reviews.apache.org/r/59883/diff/5/
Testing
-------
Modify unit tests to add constructor parameter
Run Scheduler manually configured to check that still working properly
Thanks,
Ruben D. Porras
Re: Review Request 59883: Support specifying a custom
ShiroCredentialsMatcher
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review178552
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On June 20, 2017, 10:47 p.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 10:47 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Support specifying a custom
ShiroCredentialsMatcher
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review178423
-----------------------------------------------------------
I will run the e2e tests and ship it in case they succeed.
- Stephan Erb
On June 20, 2017, 10:47 p.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 10:47 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>