You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2015/12/02 23:33:23 UTC
Re: Review Request 40850: GMSJoinLease junit tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40850/#review108730
-----------------------------------------------------------



gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 1479)
<https://reviews.apache.org/r/40850/#comment168197>

    Add a protected method to return the prepareProcessor and remove these test methods.



gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 1532)
<https://reviews.apache.org/r/40850/#comment168198>

    this is providing multithreaded access to the "waiting" variable, which is not set up for multithreaded access.  Make "waiting" a volatile variable.



gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java (line 807)
<https://reviews.apache.org/r/40850/#comment168185>

    any() shouldn't be used with verify() as it doesn't perform the verification you think it does.  You should use isA()



gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java (line 824)
<https://reviews.apache.org/r/40850/#comment168190>

    You should pull my change that renames BYPASS_DISCOVERY to BYPASS_DISCOVERY_PROPERTY



gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java (line 835)
<https://reviews.apache.org/r/40850/#comment168191>

    You should remove the property
    System.getProperties().remove(...)



gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java (line 861)
<https://reviews.apache.org/r/40850/#comment168193>

    remove the property



gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java (line 891)
<https://reviews.apache.org/r/40850/#comment168194>

    remove the property


- Bruce Schuchardt


On Dec. 2, 2015, 6:13 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40850/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 6:13 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Jason Huynh, and Jianxia Chen.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GMSJoinLease junit tests
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 2f8d734 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java e49e4ae 
> 
> Diff: https://reviews.apache.org/r/40850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>