[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #261: Implement Write-ahead Logging

["hanahmily (via GitHub)" <gi...@apache.org>]

hanahmily commented on code in PR #261:
URL: https://github.com/apache/skywalking-banyandb/pull/261#discussion_r1145552462


##########
pkg/wal/wal.go:
##########
@@ -43,18 +118,364 @@ type WAL interface {
 	// Write a logging entity.
 	// It will return immediately when the data is written in the buffer,
 	// The returned function will be called when the entity is flushed on the persistent storage.
-	Write(seriesID common.SeriesID, timestamp time.Time, data []byte) (func(), error)
+	Write(seriesID common.SeriesID, timestamp time.Time, data []byte) error

Review Comment:
   I found a gap in implementing the Buffer. The seriesID's type should be `[]byte` instead of `common.SeriesID`. 
   
   The reason is that the key in underlying storage comprises the seriesID and tagFamily as https://github.com/apache/skywalking-banyandb/blob/main/banyand/tsdb/series_write.go#L194 indicates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org