You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/07/03 06:25:52 UTC

[GitHub] [incubator-paimon] JingsongLi opened a new pull request, #1488: [flink] Refactor Delete Pushdown

JingsongLi opened a new pull request, #1488:
URL: https://github.com/apache/incubator-paimon/pull/1488

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   https://github.com/apache/incubator-paimon/pull/1434 has some problem:
   1. naming.
   2. Redundant implementation in visitor.
   3. Purge table is not implemented.
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi merged pull request #1488: [flink] Refactor Delete Pushdown

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1488:
URL: https://github.com/apache/incubator-paimon/pull/1488


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] legendtkl commented on a diff in pull request #1488: [flink] Refactor Delete Pushdown

Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on code in PR #1488:
URL: https://github.com/apache/incubator-paimon/pull/1488#discussion_r1250395259


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkTableSink.java:
##########
@@ -201,7 +196,10 @@ private void checkDeletable() {
                             "merge engine '%s' can not support delete, currently only %s can support delete.",
                             options.get(MERGE_ENGINE), MergeEngine.DEDUPLICATE));
         } else if (table instanceof ChangelogValueCountFileStoreTable) {
-            return;
+            throw new UnsupportedOperationException(

Review Comment:
   PR https://github.com/apache/incubator-paimon/pull/1216 made this changed. I'm not sure why roll it back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] legendtkl commented on a diff in pull request #1488: [flink] Refactor Delete Pushdown

Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on code in PR #1488:
URL: https://github.com/apache/incubator-paimon/pull/1488#discussion_r1250395259


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkTableSink.java:
##########
@@ -201,7 +196,10 @@ private void checkDeletable() {
                             "merge engine '%s' can not support delete, currently only %s can support delete.",
                             options.get(MERGE_ENGINE), MergeEngine.DEDUPLICATE));
         } else if (table instanceof ChangelogValueCountFileStoreTable) {
-            return;
+            throw new UnsupportedOperationException(

Review Comment:
   PR https://github.com/apache/incubator-paimon/pull/1216 made this changed, return RowLevelDelete for table ChangelogValueCountFileStoreTable. 
   
   Why does this PR roll it back?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] legendtkl commented on a diff in pull request #1488: [flink] Refactor Delete Pushdown

Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on code in PR #1488:
URL: https://github.com/apache/incubator-paimon/pull/1488#discussion_r1250395259


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkTableSink.java:
##########
@@ -201,7 +196,10 @@ private void checkDeletable() {
                             "merge engine '%s' can not support delete, currently only %s can support delete.",
                             options.get(MERGE_ENGINE), MergeEngine.DEDUPLICATE));
         } else if (table instanceof ChangelogValueCountFileStoreTable) {
-            return;
+            throw new UnsupportedOperationException(

Review Comment:
   PR https://github.com/apache/incubator-paimon/pull/1216 made this changed, return RowLevelDelete for table ChangelogValueCountFileStoreTable. I'm not sure why roll it back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org