You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2014/02/03 16:22:09 UTC

[jira] [Commented] (LUCENE-5431) Add FSLockFactory.toString()

    [ https://issues.apache.org/jira/browse/LUCENE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889547#comment-13889547 ] 

Michael McCandless commented on LUCENE-5431:
--------------------------------------------

+1 for patch and to just use .getSimpleName() in the toString.

> Add FSLockFactory.toString()
> ----------------------------
>
>                 Key: LUCENE-5431
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5431
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/store
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-5431.patch
>
>
> FSLockFactory doesn't override toString, which causes Dir.toString() to print the class.name@instance. I think it would be better if it printed e.g. the lockDir.
> I added it but TestCrashCausesCorruptIndex failed because it declares a Directory which doesn't override getLockID(), which returns toString(). I changed that Directory to extend FilterDirectory, and fixed FilterDirectory to override getLockID() to call in.getLockID().
> Will attach a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org