You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Grant Ingersoll (JIRA)" <ji...@apache.org> on 2008/08/05 14:54:46 UTC
[jira] Created: (MAHOUT-72) Separate out Examples from Core
Separate out Examples from Core
-------------------------------
Key: MAHOUT-72
URL: https://issues.apache.org/jira/browse/MAHOUT-72
Project: Mahout
Issue Type: Improvement
Reporter: Grant Ingersoll
Priority: Minor
Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (MAHOUT-72) Separate out Examples from Core
Posted by Robin Anil <ro...@gmail.com>.
In that case will the core(say a classfier or a clustering program) be
having both a Command line interface and Programming Interface(a Driver
class) or just the latter?
On Tue, Aug 5, 2008 at 6:24 PM, Grant Ingersoll (JIRA) <ji...@apache.org>wrote:
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Minor
>
>
> Let's make the Examples standalone as a separate module w/ a separate
> build, as they aren't "core".
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Robin Anil
Senior Dual Degree Student
Department of Computer Science & Engineering
IIT Kharagpur
--------------------------------------------------------------------------------------------
techdigger.wordpress.com
A discursive take on the world around us
www.minekey.com
You Might Like This
www.ithink.com
Express Yourself
Re: [jira] Updated: (MAHOUT-72) Separate out Examples from Core
Posted by Sean Owen <sr...@gmail.com>.
I mean looks OK to me. Perhaps we tweak it a bit once its in place. I
have a hard time reading it in a diff anyway.
On Thu, Aug 14, 2008 at 9:27 AM, Karl Wettin (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
[jira] Resolved: (MAHOUT-72) Separate out Examples from Core
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll resolved MAHOUT-72.
-----------------------------------
Resolution: Fixed
Looks like we are in pretty good shape here.
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Fix For: 0.1
>
> Attachments: examples-dependencies.patch, MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-72) Separate out Examples from Core
Posted by "Deneche A. Hakim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deneche A. Hakim updated MAHOUT-72:
-----------------------------------
Attachment: examples-dependencies.patch
I modified the examples build file, now when you run 'ant compile' from the examples project, it will call the compile task from the core project. I also added a dependecy between the examples task 'compile-test' and the core task 'compile-test' because the example tests may require some files from the core tests (eg. DummyOutputCollector)
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: examples-dependencies.patch, MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin updated MAHOUT-72:
------------------------------
Attachment: MAHOUT-72.txt
This does all the stuff required, but I'm sure people will have lots of comments about how I've set up the deps. We should probably also have some top level properties that are passed down to (both Maven and Ant) modules with the version number, et c.
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Minor
> Attachments: MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624302#action_12624302 ]
Karl Wettin commented on MAHOUT-72:
-----------------------------------
bq. core/lib/easymock.jar and core/lib/easymockclassextension.jar should move to trunk/lib
Where in core is easymock used? I only seem to find dependencies to it from examples. Perhaps it's something nested?
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Fix For: 0.1
>
> Attachments: examples-dependencies.patch, MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by Sean Owen <sr...@gmail.com>.
svn delete and svn add is fine by me, if it comes down to it. Yeah you
lose the continuous change history, that's about it.
I consider myself an Ant ace, happy to help if there are any issues. I
don't think a top-level build file needs to do much more than
<antcall> to targets in the subdirectory scripts.
On Wed, Aug 13, 2008 at 9:21 AM, Karl Wettin <ka...@gmail.com> wrote:
>
> 12 aug 2008 kl. 16.06 skrev Karl Wettin (JIRA):
>>
>> Actually, the patch looks a bit funky, I used svn mv
>> core/src/main/examples examples/src/main/java, but it doesn't seem to have
>> moved them at all in the patch, just deleted them?
>
> Does anyone know what I did wrong? Do I perhaps need to do something more
> than svn mv?
>
> I'll start looking at a top level Ant build too, but I'm rather lame when it
> comes to Ant. I'll just look at the Lucene build and see if I can use that.
>
>
> karl
>
Re: [jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by Thilo Goetz <tw...@gmx.de>.
All I know is that file moves/renames don't work well in
patches. It's better to do them directly in svn, or have
somebody with sufficient karma do it. That's been my
experience, anyway.
--Thilo
Karl Wettin wrote:
>
> 12 aug 2008 kl. 16.06 skrev Karl Wettin (JIRA):
>>
>> Actually, the patch looks a bit funky, I used svn mv
>> core/src/main/examples examples/src/main/java, but it doesn't seem to
>> have moved them at all in the patch, just deleted them?
>
> Does anyone know what I did wrong? Do I perhaps need to do something
> more than svn mv?
>
> I'll start looking at a top level Ant build too, but I'm rather lame
> when it comes to Ant. I'll just look at the Lucene build and see if I
> can use that.
>
>
> karl
Re: [jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by Karl Wettin <ka...@gmail.com>.
12 aug 2008 kl. 16.06 skrev Karl Wettin (JIRA):
>
> Actually, the patch looks a bit funky, I used svn mv core/src/main/
> examples examples/src/main/java, but it doesn't seem to have moved
> them at all in the patch, just deleted them?
Does anyone know what I did wrong? Do I perhaps need to do something
more than svn mv?
I'll start looking at a top level Ant build too, but I'm rather lame
when it comes to Ant. I'll just look at the Lucene build and see if I
can use that.
karl
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621825#action_12621825 ]
Karl Wettin commented on MAHOUT-72:
-----------------------------------
Actually, the patch looks a bit funky, I used svn mv core/src/main/examples examples/src/main/java, but it doesn't seem to have moved them at all in the patch, just deleted them?
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Minor
> Attachments: MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622653#action_12622653 ]
Karl Wettin commented on MAHOUT-72:
-----------------------------------
I'm leaving this patch open for now as I want the top level build to copy all jars at dist time and I want shared properties. Perhaps it makes more sense with a new issue for that? We should also move example-only related jars (j2ee, anything else?) to examples/lib. Or perhaps we should keep all libs in the root? I can probably come up with more perhaps-questions, but lets start with these.
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Minor
> Attachments: MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623618#action_12623618 ]
Karl Wettin commented on MAHOUT-72:
-----------------------------------
So I moved junit to trunk/lib and j2ee to examples/lib.
I just realised that the loggers also should be located in trunk/lib
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: examples-dependencies.patch, MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by "Deneche A. Hakim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624308#action_12624308 ]
Deneche A. Hakim commented on MAHOUT-72:
----------------------------------------
bq. Where in core is easymock used? I only seem to find dependencies to it from examples. Perhaps it's something nested?
For now it is only needed in the examples tests
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Fix For: 0.1
>
> Attachments: examples-dependencies.patch, MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622667#action_12622667 ]
Grant Ingersoll commented on MAHOUT-72:
---------------------------------------
I don't think we need a new issue. A common build file seems warranted
Makes sense
I'd say just the common ones, but... I can see the case either way.
We don't have to get it perfect right now, but some separation would
be good. I still like to follow the model of keeping core as "core"
as possible, so the less pollution there, the better.
I'm less concerned about that pollution for the examples.
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by "Deneche A. Hakim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623632#action_12623632 ]
Deneche A. Hakim commented on MAHOUT-72:
----------------------------------------
_core/lib/cglib-nodep-2.1_3.jar_ should move to examples/lib because it is needed only by the examples
_core/lib/easymock.jar_ and _core/lib/easymockclassextension.jar_ should move to trunk/lib
_easymock*.jar_ should be ignored when building the job file because they are only needed for testing
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: examples-dependencies.patch, MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin updated MAHOUT-72:
------------------------------
Attachment: MAHOUT-72.txt
New module examples. Maven only.
Needs a top level Ant build and examples module Ant build extracted from the current core build.
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Minor
> Attachments: MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623617#action_12623617 ]
Karl Wettin commented on MAHOUT-72:
-----------------------------------
bq. I modified the examples build file, now when you run 'ant compile' from the examples project, it will call the compile task from the core project. I also added a dependecy between the examples task 'compile-test' and the core task 'compile-test' because the example tests may require some files from the core tests (eg. DummyOutputCollector)
Thanks, I commited this in rev 687007 together with some dependency refactoring.
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: examples-dependencies.patch, MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin updated MAHOUT-72:
------------------------------
Fix Version/s: 0.1
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Fix For: 0.1
>
> Attachments: examples-dependencies.patch, MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (MAHOUT-72) Separate out Examples from Core
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin reassigned MAHOUT-72:
---------------------------------
Assignee: Karl Wettin
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: MAHOUT-72.txt, MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.