You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/01 12:42:42 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request, #22573: Refactor MySQLBinlogEventType.valueOf to support unknown event type

sandynz opened a new pull request, #22573:
URL: https://github.com/apache/shardingsphere/pull/22573

   
   Changes proposed in this pull request:
     - Refactor MySQLBinlogEventType.valueOf to return Optional result
     - Add more binlog event type, based on `binlog_event.h`
     - Update binlog event type value from hexadecimal to decimal, for easier code reading
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #22573: Refactor MySQLBinlogEventType.valueOf to support unknown event type

Posted by GitBox <gi...@apache.org>.

sandynz commented on PR #22573:
URL: https://github.com/apache/shardingsphere/pull/22573#issuecomment-1334702280

   Hi @TeslaCN , I updated `MySQLBinlogEventType`, it's used by pipeline, and also used by mysql-protocol, could you help to have a look at the changes when you have time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #22573: Refactor MySQLBinlogEventType.valueOf to support unknown event type

Posted by GitBox <gi...@apache.org>.

sandynz commented on PR #22573:
URL: https://github.com/apache/shardingsphere/pull/22573#issuecomment-1333716732

   Example exception:
   ```
   Caused by: java.lang.IllegalArgumentException: Can not find value `38` in binlog event type
   	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:190)
   	at org.apache.shardingsphere.db.protocol.mysql.constant.MySQLBinlogEventType.valueOf(MySQLBinlogEventType.java:125)
   	at org.apache.shardingsphere.data.pipeline.mysql.ingest.client.netty.MySQLBinlogEventPacketDecoder.decodeEvent(MySQLBinlogEventPacketDecoder.java:78)
   	at org.apache.shardingsphere.data.pipeline.mysql.ingest.client.netty.MySQLBinlogEventPacketDecoder.decode(MySQLBinlogEventPacketDecoder.java:72)
   	at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:529)
   	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:468)
   	... 25 common frames omitted
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] azexcy merged pull request #22573: Refactor MySQLBinlogEventType.valueOf to support unknown event type

Posted by GitBox <gi...@apache.org>.

azexcy merged PR #22573:
URL: https://github.com/apache/shardingsphere/pull/22573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #22573: Refactor MySQLBinlogEventType.valueOf to support unknown event type

Posted by GitBox <gi...@apache.org>.

TeslaCN commented on PR #22573:
URL: https://github.com/apache/shardingsphere/pull/22573#issuecomment-1334704717

   > Hi @TeslaCN , I updated `MySQLBinlogEventType`, it's used by pipeline, and also used by mysql-protocol, could you help to have a look at the changes when you have time?
   
   These changes are acceptable. `MySQLBinlogEventType` is only used by pipeline for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org