[GitHub] [druid] gianm commented on a diff in pull request #14247: Define DruidInputSource getTypes() method

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on code in PR #14247:
URL: https://github.com/apache/druid/pull/14247#discussion_r1190290475


##########
indexing-service/src/main/java/org/apache/druid/indexing/input/DruidInputSource.java:
##########
@@ -179,6 +183,14 @@ public DruidInputSource(
     this.taskConfig = Preconditions.checkNotNull(taskConfig, "null taskConfig");
   }
 
+  @JsonIgnore
+  @Nonnull
+  @Override
+  public Set<String> getTypes()
+  {
+    return ImmutableSet.of();

Review Comment:
   Should be `ImmutableSet.of("druid")`, otherwise permissions won't be appropriately checked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org