You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/10/12 17:44:28 UTC
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8265
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
[DOCS] Fix alphabetical ordering of query options
There were 2 DE options out of order amongst the DI
ones:
DEBUG_ACTION
DEFAULT_JOIN_DISTRIBUTION_MODE
DEFAULT_ORDER_BY_LIMIT
DISABLE_CODEGEN
DECIMAL_V2
DEFAULT_SPILLABLE_BUFFER_SIZE
Moved DECIMAL_V2 and DEFAULT_SPILLABLE_BUFFER_SIZE
to the right respective positions.
Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
---
M docs/impala.ditamap
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8265/1
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 )
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
Patch Set 2: Code-Review+1
Absolutely perfect! Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 20:23:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 )
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
Patch Set 1:
This is easy to verify from a newly built PDF. The reordered topics are under SQL Language Reference > SQL Statements > SET Statement > Query Options for SET Statement.
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 17:46:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 )
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
Patch Set 1:
The alphabetization of the statements that start with "D" look great, but shouldn't "SCHEDULE_RANDOM_REPLICA" be listed before "SCRATCH_LIMIT"?
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 20:02:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 )
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/168/
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 20:25:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 )
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 20:30:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Laurel Hale,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8265
to look at the new patch set (#2).
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
[DOCS] Fix alphabetical ordering of query options
There were 2 DE options out of order amongst the DI
ones:
DEBUG_ACTION
DEFAULT_JOIN_DISTRIBUTION_MODE
DEFAULT_ORDER_BY_LIMIT
DISABLE_CODEGEN
DECIMAL_V2
DEFAULT_SPILLABLE_BUFFER_SIZE
Moved DECIMAL_V2 and DEFAULT_SPILLABLE_BUFFER_SIZE
to the right respective positions.
Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
---
M docs/impala.ditamap
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8265/2
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 )
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
Patch Set 2:
Sure, why not. Oh for some automation around all that.
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 20:05:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8265 )
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
[DOCS] Fix alphabetical ordering of query options
There were 2 DE options out of order amongst the DI
ones:
DEBUG_ACTION
DEFAULT_JOIN_DISTRIBUTION_MODE
DEFAULT_ORDER_BY_LIMIT
DISABLE_CODEGEN
DECIMAL_V2
DEFAULT_SPILLABLE_BUFFER_SIZE
Moved DECIMAL_V2 and DEFAULT_SPILLABLE_BUFFER_SIZE
to the right respective positions.
Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Reviewed-on: http://gerrit.cloudera.org:8080/8265
Reviewed-by: Laurel Hale <la...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala.ditamap
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Laurel Hale: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 )
Change subject: [DOCS] Fix alphabetical ordering of query options
......................................................................
Patch Set 2: Code-Review+2
OK, promoting to +2.
--
To view, visit http://gerrit.cloudera.org:8080/8265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8
Gerrit-Change-Number: 8265
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 20:24:57 +0000
Gerrit-HasComments: No