You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/05 21:53:17 UTC

[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #444: SAMA5D27 peripheral support - USB Host working

adamfeuer opened a new pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444
 
 
   ### Summary
   
   * SAMA5D27 USB Host support working
   * Other peripherals added as a work in progress, but not tested
   * Minor nxstyle fixes for some SAMA5D3-Xplained files
   * USB Host fixes and testing by @centurysys (Takeyoshi Kikuchi)
   * Testing help from @patacongo 
   
   ### Impact
   
   * None if you aren't using the SAMA5D27
   * Adds USB Host support work for the SAMA5D27
   * Adds support for other peripherals but these haven't been tested.
   
   ### Limitations / TODO
   
   * Test the other peripherals, especially SPI, I2C, and Ethernet
   
   ### Detail
   
   * Much code was copied from the SAMA5D3-Xplained board files. Maybe this should eventually be deduplicated?
   
   ### Testing
   
   * Manual with USB flash driver and USB keyboard
   
   ### How To Verify
   
   * Configure using the SAMA5D27-XULT defconfig.
   * Compile and run
   * Plug in a USB flash drive with some files on it
   * Do the following in NuttX:
   
   ```
   NuttShell (NSH) NuttX-8.2
   nsh>ls /dev
   /dev:
    console
    null
    ramlog
    random
    sda
    ttyS0
    zero
   nsh>mkdir /mnt/usb
   nsh>mount -t vfat /dev/sda /mnt/usb
   nsh>ls /mnt/usb
   /mnt/usb:
    foo.txt
    bar.txt
   nsh>cat /mnt/usb/bar.txt
   0
   1
   2
   3
   4
   5
   6
   7
   8
   9
   Hello, World!
   
   ```
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo merged pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388631703
 
 

 ##########
 File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig
 ##########
 @@ -26,27 +26,40 @@ CONFIG_AUDIO_NUM_BUFFERS=8
 CONFIG_BOARD_LOOPSPERMSEC=65775
 CONFIG_BOOT_RUNFROMSDRAM=y
 CONFIG_BUILTIN=y
+CONFIG_CDCACM=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_USB=y
+CONFIG_DEBUG_USB_INFO=y
+CONFIG_DEBUG_WARN=y
 
 Review comment:
   Also, any new configurations or any changes to existing configurations need to be documented in the board's README.txt file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593179

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_can.c
##########
@@ -0,0 +1,115 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_can.c
+ *
+ * Copyright (C) 2014, 2016 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388606192
 
 

 ##########
 File path: boards/arm/sama5/sama5d2-xult/src/Makefile
 ##########
 @@ -1,7 +1,7 @@
 ############################################################################
-# boards/arm/sama5/sama5d2-xult/src/Makefile
+# boards/arm/sama5/sama5d3-xplained/src/Makefile
 #
-#   Copyright (C) 2015 Gregory Nutt. All rights reserved.
+#   Copyright (C) 2014 Gregory Nutt. All rights reserved.
 
 Review comment:
   @patacongo I probably copied the entire file from the SAMA5D3-Xplained to get the peripherals to work. I will update to 2020.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388598106

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_ajoystick.c
##########
@@ -0,0 +1,452 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_ajoystick.c
+ *
+ * Copyright (C) 2014, 2016, 2018 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597796
 
 

 ##########
 File path: boards/arm/sama5/sama5d2-xult/src/Makefile
 ##########
 @@ -1,7 +1,7 @@
 ############################################################################
-# boards/arm/sama5/sama5d2-xult/src/Makefile
+# boards/arm/sama5/sama5d3-xplained/src/Makefile
 #
-#   Copyright (C) 2015 Gregory Nutt. All rights reserved.
+#   Copyright (C) 2014 Gregory Nutt. All rights reserved.
 
 Review comment:
   Why the the copyright date go backward in time?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595502991
 
 
   @patacongo Thanks for the improvements. I think I made all the suggested fixes, will you take a look and see if there's anything else I need to do?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595974

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593267

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_ethernet.c
##########
@@ -0,0 +1,343 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_ethernet.c
+ *
+ * Copyright (C) 2014, 2017 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596015
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -141,6 +144,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
         }
 #endif
 #ifdef CONFIG_SAMA5_PIOD_IRQ
+
 
 Review comment:
   The blank line belongs after line 145, not here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593555

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_hsmci.c
##########
@@ -0,0 +1,344 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_hsmci.c
+ *
+ * Copyright (C) 2014 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388605242
 
 

 ##########
 File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig
 ##########
 @@ -8,7 +8,7 @@
 # CONFIG_AUDIO_FORMAT_MP3 is not set
 
 Review comment:
   @patacongo Will fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595505733
 
 
   There are quite a few things here.  Perhaps you can "Resolve conversation" when the changes are in place.  Once all of the conversations have been resoved, I will do the merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388594257

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_usbmsc.c
##########
@@ -0,0 +1,108 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_usbmsc.c
+ *
+ * Copyright (C) 2014, 2016 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Configure and register the SAM3U MMC/SD SDIO block driver.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596891
 
 

 ##########
 File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h
 ##########
 @@ -80,6 +81,7 @@
 #define SAM_EBICS3_PSECTION      0x60000000 /* 0x60000000-0x6fffffff: EBI Chip select 2 */
 #define SAM_NFCCR_PSECTION       0x70000000 /* 0x70000000-0x7fffffff: NFC Command Registers */
                                             /* 0x80000000-0xefffffff: Undefined */
+
 
 Review comment:
   @patacongo Ok, will remove these blank lines. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592223

##########
File path: boards/arm/sama5/sama5d2-xult/include/board_498mhz.h
##########
@@ -0,0 +1,217 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d2-xult/include/board_498mhz.h
+ *
+ * Copyright (C) 2015 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593973

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_spi.c
##########
@@ -0,0 +1,194 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_spi.c
+ *
+ * Copyright (C) 2014 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593823

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_ostest.c
##########
@@ -0,0 +1,114 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_ostest.c
+ *
+ * Copyright (C) 2014 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596110

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596219
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -157,6 +162,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
         }
 #endif
 #ifdef CONFIG_SAMA5_PIOF_IRQ
+
 
 Review comment:
   The blank line belongs after line 163, not here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597128
 
 

 ##########
 File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig
 ##########
 @@ -8,7 +8,7 @@
 # CONFIG_AUDIO_FORMAT_MP3 is not set
 
 Review comment:
   Please do not modify the generic nsh configuration.  People expect nsh configurations to be simple.  Please create a new configuration, perhaps called netnsh (as for other configurations).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388630698

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596036

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_nandflash.c
##########
@@ -0,0 +1,234 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_nandflash.c
+ *
+ * Copyright (C) 2014 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Most of this file derives from Atmel sample code for the SAMA5D3-Xplained
+ * board. That sample code has licensing that is compatible with the NuttX
+ * modified BSD license:
+ *
+ * Copyright (c) 2012, Atmel Corporation
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor Atmel nor the names of its contributors may
+ * be used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595508795
 
 
   @patacongo Thanks— I went through the changed files view and looked to make sure I took care of everything. I resolved all the conversations with your suggestions. It should be good to merge now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596094
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -149,6 +153,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
         }
 #endif
 #ifdef CONFIG_SAMA5_PIOE_IRQ
+
 
 Review comment:
   The blank line belongs after line 154, not here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592952

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_adc.c
##########
@@ -0,0 +1,101 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_adc.c
+ *
+ * Copyright (C) 2014 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593741

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597096
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -157,6 +162,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
         }
 #endif
 #ifdef CONFIG_SAMA5_PIOF_IRQ
+
 
 Review comment:
   @patacongo Will fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595940

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_at25.c
##########
@@ -0,0 +1,143 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_at25.c
+ *
+ * Copyright (C) 2014 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592910

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388606207
 
 

 ##########
 File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig
 ##########
 @@ -26,27 +26,40 @@ CONFIG_AUDIO_NUM_BUFFERS=8
 CONFIG_BOARD_LOOPSPERMSEC=65775
 CONFIG_BOOT_RUNFROMSDRAM=y
 CONFIG_BUILTIN=y
+CONFIG_CDCACM=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_USB=y
+CONFIG_DEBUG_USB_INFO=y
+CONFIG_DEBUG_WARN=y
 
 Review comment:
   @patacongo Will fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595455
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -117,6 +117,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
   if (irq >= SAM_IRQ_NINT)
     {
 #ifdef CONFIG_SAMA5_PIOA_IRQ
+
 
 Review comment:
   There should be no blank line here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596066

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596967
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -125,6 +126,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
         }
 #endif
 #ifdef CONFIG_SAMA5_PIOB_IRQ
+
 
 Review comment:
   @patacongo Will fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595921500
 
 
   @liuguo09 @patacongo This is my mistake, I am sorry! I'm working on a fix for this file right now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388605409

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593896

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_pwm.c
##########
@@ -0,0 +1,162 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_pwm.c
+ *
+ * Copyright (C) 2014-2016 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595906

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593634

##########
File path: boards/arm/sama5/sama5d2-xult/src/sam_i2schar.c
##########
@@ -0,0 +1,126 @@
+/****************************************************************************
+ * boards/arm/sama5/sama5d3-xplained/src/sam_i2schar.c
+ *
+ * Copyright (C) 2014 Gregory Nutt. All rights reserved.
+ * Author: Gregory Nutt <gn...@nuttx.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/

Review comment:
All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596011

Review comment:
@patacongo Will fix.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595144
 
 

 ##########
 File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h
 ##########
 @@ -80,6 +81,7 @@
 #define SAM_EBICS3_PSECTION      0x60000000 /* 0x60000000-0x6fffffff: EBI Chip select 2 */
 #define SAM_NFCCR_PSECTION       0x70000000 /* 0x70000000-0x7fffffff: NFC Command Registers */
                                             /* 0x80000000-0xefffffff: Undefined */
+
 
 Review comment:
   These were unnecessary.  THIS is an error from nxstyle (and is documented in the Issues).  There should be no blank line follow comments to the right such as in this case.  It would be better to remove these blank lines.
   
   Many other similar cases below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] liuguo09 commented on issue #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

liuguo09 commented on issue #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595864937
 
 
   It seems this PR build breaks sama5d3x-ek:nsh config as below:
   
   It is mainly because of arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h update in this PR.
   
   chip/sam_memories.c: In function 'periphb_physregaddr':
   chip/sam_memories.c:86:5: warning: "SAM_PERIPHB_PSECTION" is not defined, evaluates to 0 [-Wundef]
      86 | #if SAM_PERIPHB_PSECTION != SAM_PERIPHB_VSECTION
         |     ^~~~~~~~~~~~~~~~~~~~
   chip/sam_memories.c:95:10: error: 'SAM_PERIPHB_PSECTION' undeclared (first use in this function); did you mean 'SAM_PERIPHA_PSECTION'?
      95 |   return SAM_PERIPHB_PSECTION + sectoffset;
         |          ^~~~~~~~~~~~~~~~~~~~
         |          SAM_PERIPHA_PSECTION
   chip/sam_memories.c:95:10: note: each undeclared identifier is reported only once for each function it appears in
   chip/sam_memories.c: In function 'sysc_physregaddr':
   chip/sam_memories.c:149:5: warning: "SAM_SYSC_PSECTION" is not defined, evaluates to 0 [-Wundef]
     149 | #if SAM_SYSC_PSECTION != SAM_SYSC_VSECTION
         |     ^~~~~~~~~~~~~~~~~
   chip/sam_memories.c:158:10: error: 'SAM_SYSC_PSECTION' undeclared (first use in this function); did you mean 'SAM_SYSC_VSECTION'?
     158 |   return SAM_SYSC_PSECTION + sectoffset;
         |          ^~~~~~~~~~~~~~~~~
         |          SAM_SYSC_VSECTION
   chip/sam_memories.c: In function 'sam_physregaddr':
   chip/sam_memories.c:701:45: error: 'SAM_PERIPHA_SIZE' undeclared (first use in this function); did you mean 'SAM_PERIPHB_SIZE'?
     701 |       virtregaddr < (SAM_PERIPHA_VSECTION + SAM_PERIPHA_SIZE))
         |                                             ^~~~~~~~~~~~~~~~
         |                                             SAM_PERIPHB_SIZE
   make[1]: *** [sam_memories.o] Error 1
   make: *** [arch/arm/src/libarch.a] Error 2
   make: *** Waiting for unfinished jobs....
   ##[error]Process completed with exit code 2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597444
 
 

 ##########
 File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig
 ##########
 @@ -26,27 +26,40 @@ CONFIG_AUDIO_NUM_BUFFERS=8
 CONFIG_BOARD_LOOPSPERMSEC=65775
 CONFIG_BOOT_RUNFROMSDRAM=y
 CONFIG_BUILTIN=y
+CONFIG_CDCACM=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_USB=y
+CONFIG_DEBUG_USB_INFO=y
+CONFIG_DEBUG_WARN=y
 
 Review comment:
   No DEBUG configurations are permitted on commited defconfig files.  Please remove these.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596923
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -117,6 +117,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
   if (irq >= SAM_IRQ_NINT)
     {
 #ifdef CONFIG_SAMA5_PIOA_IRQ
+
 
 Review comment:
   @patacongo Will fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597017
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -141,6 +144,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
         }
 #endif
 #ifdef CONFIG_SAMA5_PIOD_IRQ
+
 
 Review comment:
   @patacongo Will fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595626
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -125,6 +126,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
         }
 #endif
 #ifdef CONFIG_SAMA5_PIOB_IRQ
+
 
 Review comment:
   The blank line belongs after line 127, not here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595871
 
 

 ##########
 File path: arch/arm/src/sama5/sam_pioirq.c
 ##########
 @@ -133,6 +135,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
         }
 #endif
 #ifdef CONFIG_SAMA5_PIOC_IRQ
+
 
 Review comment:
   The blank line belongs after line 136, not here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working

Posted by GitBox <gi...@apache.org>.

adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595927381
 
 
   @liuguo09 The fix is in #464, will you check it out and see if it works for you? It builds and runs ok on my SAMA5D3-Xplained board.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services