You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/10/22 15:14:31 UTC
[I] Deprecate `ScalarUDFImpl::invoke` [datafusion]
alamb opened a new issue, #13064:
URL: https://github.com/apache/datafusion/issues/13064
### Is your feature request related to a problem or challenge?
in https://github.com/apache/datafusion/pull/13001 @agscpp added a general function `ScalarUDFImpl::invoke_batche` that handles inputs with 0 and more than 0 arguments.
Previously, there were two separate functions to handle these cases:
1. https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.ScalarUDFImpl.html#tymethod.invoke
2. https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.ScalarUDFImpl.html#method.invoke_no_args
### Describe the solution you'd like
I would like to mark `invoke` and `invoke_no_args` deprecated
### Describe alternatives you've considered
1. Mark the functions deprecated, with a message to implement `invoke_batch` instead. for example
https://github.com/apache/datafusion/blob/c22abb4ac3f1af8bbdf176ef0198988fc7b0982c/datafusion/expr/src/expr.rs#L1125
2. Update the documentation so `invoke_batch` is the main API and the documentation reflects that
3. Update the DataFusion codebase so that the `ScalarUDFImpl`s use invoke_batch rather than `invoke` and `invoke_udf`
### Additional context
I think this is pretty well specified and largely mechanical so it would be a good first issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Deprecate `ScalarUDFImpl::invoke` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #13064: Deprecate `ScalarUDFImpl::invoke`
URL: https://github.com/apache/datafusion/issues/13064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Deprecate `ScalarUDFImpl::invoke` [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on issue #13064:
URL: https://github.com/apache/datafusion/issues/13064#issuecomment-2468828981
Sorry for duplicating this in https://github.com/apache/datafusion/issues/13238. It's already in progress, so let's maybe close this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Deprecate `ScalarUDFImpl::invoke` [datafusion]
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on issue #13064:
URL: https://github.com/apache/datafusion/issues/13064#issuecomment-2429571326
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org