You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/04 14:48:02 UTC
[GitHub] [incubator-doris] morningman commented on a change in pull request #6358: Internal error code
morningman commented on a change in pull request #6358:
URL: https://github.com/apache/incubator-doris/pull/6358#discussion_r682687130
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
##########
@@ -124,10 +125,19 @@ private void auditAfterExec(String origStmt, StatementBase parsedStmt, Data.PQue
if (ctx.getState().isQuery()) {
MetricRepo.COUNTER_QUERY_ALL.increase(1L);
- if (ctx.getState().getStateType() == QueryState.MysqlStateType.ERR
- && ctx.getState().getErrType() != QueryState.ErrType.ANALYSIS_ERR) {
- // err query
- MetricRepo.COUNTER_QUERY_ERR.increase(1L);
+ if (ctx.getState().getStateType() == QueryState.MysqlStateType.ERR) {
+ InternalErrorCode errorCode = ctx.getState().getInternalErrorCode();
+ if (errorCode == InternalErrorCode.INTERNAL_ERR) {
+ // err query
+ MetricRepo.COUNTER_QUERY_ERR.increase(1L);
+ } else {
+ MetricRepo.COUNTER_QUERY_ERR_OTHER.increase(1L);
+ MetricRepo.HISTO_QUERY_LATENCY.update(elapseMs);
Review comment:
Why update `HISTO_QUERY_LATENCY` for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org