Re: [I] Fix timeline check for meta sync [hudi]

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on issue #15977:
URL: https://github.com/apache/hudi/issues/15977#issuecomment-4795511274

   This appears to already be fixed by [HUDI-6389](https://issues.apache.org/jira/browse/HUDI-6389) / [PR #8991](https://github.com/apache/hudi/pull/8991), commit `db741da47ba4` (June 2023). That change updated `TimelineUtils.getCommitsTimelineAfter` to call `isBeforeTimelineStarts` on the **write timeline** (which excludes `ROLLBACK_ACTION` via `BaseTimelineV2.getWriteTimeline`) instead of the full active timeline.
   
   In the scenario described:
   - active timeline: `ts3.rollback, ts50.commit, ts51.commit, ts52.commit`
   - write timeline: `ts50.commit, ts51.commit, ts52.commit`
   - `writeTimeline.isBeforeTimelineStarts("ts47")` → first non-savepoint commit is `ts50`, `ts47 < ts50` → returns `true` → archived timeline is loaded and `ts48`/`ts49` are included for meta sync.
   
   Current master still carries the fix at `hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java:320-324`. Looks like this issue can be closed as a duplicate of HUDI-6389. If there's a different scenario still broken, please share a repro.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org