[GitHub] [geode] PurelyApplied opened pull request #3238: GEODE-6449: Move from AWS S3 jar to buildSrc source code.

["PurelyApplied (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3238 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #3238: GEODE-6449: Move from AWS S3 jar to buildSrc source code.

["PurelyApplied (GitHub)" <gi...@apache.org>]

[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/3238 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3238: GEODE-6449: Move from AWS S3 jar to buildSrc source code.

["PurelyApplied (GitHub)" <gi...@apache.org>]

Mostly at @jdeppe-pivotal but anyone else who might know:

It's still not entirely clear to me what our consumption of the `gradle-dockerized-test` plugin is / how it differs from the original source.  It was my impression that it relates to some of the docker-in-docker stuff in our CI pipeline.  If that's the case, then this precheckin should properly provide confidence that these changes aren't going to cause bad leaks in our main pipeline.

If that isn't the case, however, please direct me to what tests I should execute locally to promote confidence in this diff-set.

[ Full content available at: https://github.com/apache/geode/pull/3238 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on issue #3238: GEODE-6449: Move from AWS S3 jar to buildSrc source code.

["metatype (GitHub)" <gi...@apache.org>]

What do you think about fixing this in your PR?

`ci/images/google-geode-builder/scripts/setup.sh:JDK_URL=$(curl -Ls http://jdk.java.net/11 | awk '/linux-x64/{sub(/.*href=./,"");sub(/".*/,"");if(found!=1)print;found=1}')`

[ Full content available at: https://github.com/apache/geode/pull/3238 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on issue #3238: GEODE-6449: Move from AWS S3 jar to buildSrc source code.

["metatype (GitHub)" <gi...@apache.org>]

@PurelyApplied the line from above includes an `http` link.  We can change it to `https`.

[ Full content available at: https://github.com/apache/geode/pull/3238 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3238: GEODE-6449: Move from AWS S3 jar to buildSrc source code.

["PurelyApplied (GitHub)" <gi...@apache.org>]

Closing in favor of #3241

[ Full content available at: https://github.com/apache/geode/pull/3238 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3238: GEODE-6449: Move from AWS S3 jar to buildSrc source code.

["PurelyApplied (GitHub)" <gi...@apache.org>]

@metatype We appear to already have that line in that file?  Did your comment get truncated and I'm missing the meaningful part of a diff or something?

[ Full content available at: https://github.com/apache/geode/pull/3238 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org