You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/06 02:44:00 UTC
[GitHub] [shardingsphere] zhuoan opened a new pull request, #18883: Update OracleSchemaMetaDataLoader.java
zhuoan opened a new pull request, #18883:
URL: https://github.com/apache/shardingsphere/pull/18883
Avoid null pointer exceptions for resultSet.getString("COLLATION") ,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed pull request #18883: Update OracleSchemaMetaDataLoader.java
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #18883: Update OracleSchemaMetaDataLoader.java
URL: https://github.com/apache/shardingsphere/pull/18883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhuoan commented on pull request #18883: Update OracleSchemaMetaDataLoader.java
Posted by GitBox <gi...@apache.org>.
zhuoan commented on PR #18883:
URL: https://github.com/apache/shardingsphere/pull/18883#issuecomment-1177461569
the test case not need change，this bugfix is to fix the resultSet.getString("COLLATION") may be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #18883: Update OracleSchemaMetaDataLoader.java
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18883:
URL: https://github.com/apache/shardingsphere/pull/18883#issuecomment-1207440885
@zhuoan The progress of this PR has not been upgraded for a long time. If there is no update, I will close it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #18883: Update OracleSchemaMetaDataLoader.java
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18883:
URL: https://github.com/apache/shardingsphere/pull/18883#issuecomment-1207440800
@zhuoan The progress of this PR has not been upgraded for a long time. If there is no update, I will close it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #18883: Update OracleSchemaMetaDataLoader.java
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18883:
URL: https://github.com/apache/shardingsphere/pull/18883#issuecomment-1189780839
@zhuoan Hi, any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhuoan commented on pull request #18883: Update OracleSchemaMetaDataLoader.java
Posted by GitBox <gi...@apache.org>.
zhuoan commented on PR #18883:
URL: https://github.com/apache/shardingsphere/pull/18883#issuecomment-1177471726
> Could you update the test case?
the test case not need change，this bugfix is to fix the resultSet.getString("COLLATION") may be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #18883: Update OracleSchemaMetaDataLoader.java
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18883:
URL: https://github.com/apache/shardingsphere/pull/18883#issuecomment-1212707720
I just close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #18883: Update OracleSchemaMetaDataLoader.java
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18883:
URL: https://github.com/apache/shardingsphere/pull/18883#issuecomment-1179469480
> resultSet.getString("COLLATION")
It is better to test when `resultSet.getString("COLLATION")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org