You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by ak...@apache.org on 2004/02/14 07:16:00 UTC

svn commit: rev 6648 - in incubator/directory/eve/trunk/eve: . frontend/buffer/merlin-impl frontend/common/api/src/java/org/apache/eve/listener frontend/input/pojo-impl/src/java/org/apache/eve/input frontend/listener/spi/src/java/org/apache/eve/listener

Author: akarasulu
Date: Fri Feb 13 22:15:59 2004
New Revision: 6648

Modified:
   incubator/directory/eve/trunk/eve/frontend/buffer/merlin-impl/maven.xml
   incubator/directory/eve/trunk/eve/frontend/common/api/src/java/org/apache/eve/listener/ClientKey.java
   incubator/directory/eve/trunk/eve/frontend/input/pojo-impl/src/java/org/apache/eve/input/DefaultInputManager.java
   incubator/directory/eve/trunk/eve/frontend/listener/spi/src/java/org/apache/eve/listener/ListenerManagerMonitor.java
   incubator/directory/eve/trunk/eve/maven.xml
Log:
minor edits while going over stuff

Modified: incubator/directory/eve/trunk/eve/frontend/buffer/merlin-impl/maven.xml
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/buffer/merlin-impl/maven.xml	(original)
+++ incubator/directory/eve/trunk/eve/frontend/buffer/merlin-impl/maven.xml	Fri Feb 13 22:15:59 2004
@@ -35,4 +35,7 @@
         <attainGoal name="avalon:meta"/>
     </postGoal>
     
+  <goal name="components">
+    <j:import inherit="true" uri="components.xml"/>  
+  </goal>
 </project>

Modified: incubator/directory/eve/trunk/eve/frontend/common/api/src/java/org/apache/eve/listener/ClientKey.java
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/common/api/src/java/org/apache/eve/listener/ClientKey.java	(original)
+++ incubator/directory/eve/trunk/eve/frontend/common/api/src/java/org/apache/eve/listener/ClientKey.java	Fri Feb 13 22:15:59 2004
@@ -57,16 +57,19 @@
 
 /**
  * Every client that successfully binds anonymously or with a valid identity
- * has a unique client key represented by this class.  First and foremost the
- * key is used to uniquely identify the client based on the interface and
- * port used to connection on the server as well as the interface and port used
- * by the client.
- *
+ * has a unique client key represented by this class.  The key uniquely 
+ * identifies the client based on the connection parameters: interface and port 
+ * used on the server as well as the interface and port used by the client.
+ * <p>
  * The ClientKey plays a central role in coordinating activities with the
  * server across various threads.  Threads within the same stage or across
  * stages are synchronized on client resources using lock objects held by a
  * ClientKey instance.  Socket IO is managed using a pair of lock objects
  * specificially for this purpose.
+ * </p>
+ * 
+ * @todo do we really need these lock objects?
+ * @todo why are we carrying around the damn socket?
  *
  * @author <a href="mailto:akarasulu@apache.org">Alex Karasulu</a>
  * @author $Author$

Modified: incubator/directory/eve/trunk/eve/frontend/input/pojo-impl/src/java/org/apache/eve/input/DefaultInputManager.java
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/input/pojo-impl/src/java/org/apache/eve/input/DefaultInputManager.java	(original)
+++ incubator/directory/eve/trunk/eve/frontend/input/pojo-impl/src/java/org/apache/eve/input/DefaultInputManager.java	Fri Feb 13 22:15:59 2004
@@ -113,9 +113,9 @@
     }
     
 
-        // ------------------------------------------------------------------------
-        // start, stop and runnable code
-        // ------------------------------------------------------------------------
+    // ------------------------------------------------------------------------
+    // start, stop and runnable code
+    // ------------------------------------------------------------------------
     
     
     /**

Modified: incubator/directory/eve/trunk/eve/frontend/listener/spi/src/java/org/apache/eve/listener/ListenerManagerMonitor.java
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/listener/spi/src/java/org/apache/eve/listener/ListenerManagerMonitor.java	(original)
+++ incubator/directory/eve/trunk/eve/frontend/listener/spi/src/java/org/apache/eve/listener/ListenerManagerMonitor.java	Fri Feb 13 22:15:59 2004
@@ -57,6 +57,10 @@
 
 /**
  * Used to monitor the activities of a ListenerManager.
+ * 
+ * @todo why the heck does this interface references to an implementation object
+ * like a Selector?
+ * 
  *
  * @author <a href="mailto:aok123@bellsouth.net">Alex Karasulu</a>
  * @author $Author$

Modified: incubator/directory/eve/trunk/eve/maven.xml
==============================================================================
--- incubator/directory/eve/trunk/eve/maven.xml	(original)
+++ incubator/directory/eve/trunk/eve/maven.xml	Fri Feb 13 22:15:59 2004
@@ -1,6 +1,14 @@
-<project default="java:compile" xmlns:j="jelly:core" xmlns:u="jelly:util" 
-  xmlns:ant="jelly:ant" xmlns:maven="jelly:maven" xmlns:m="maven" 
-  xmlns:deploy="deploy">
+<?xml version="1.0" encoding="ISO-8859-1"?> 
+  
+<project 
+  default="java:compile" 
+  xmlns:j="jelly:core" 
+  xmlns:u="jelly:util" 
+  xmlns:ant="jelly:ant" 
+  xmlns:maven="jelly:maven" 
+  xmlns:m="maven" 
+  xmlns:deploy="deploy"
+  >
   
   <preGoal name="site">
     <attainGoal name="docbook:transform"/>
@@ -12,7 +20,9 @@
   </postGoal>
 
   <goal name="subproject:collectdocs">
-    <ant:copy toDir="../../../sitedocs/trunk/sitedocs/target/docs/subprojects/eve">
+    <ant:copy 
+      toDir="../../../sitedocs/trunk/sitedocs/target/docs/subprojects/eve">
+      
       <ant:fileSet dir="${basedir}/target/docs">
         <ant:include name="**"/>
       </ant:fileSet>
@@ -62,4 +72,13 @@
       includes="*/project.xml" goals="eclipse" banner="Eclipse Project" 
       ignoreFailures="true"/>
   </goal>
+  
+  <!-- ========================================================================
+    Experimentation section starts here!
+    ======================================================================= -->
+  
+  <goal name="components">
+    <j:import inherit="true" uri="components.xml"/>  
+  </goal>
+    
 </project>