You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/09/07 16:13:50 UTC
[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4325
Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
......................................................................
IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
The test previously got the "initial" value of number of fragments by
reading the metric. This gave an incorrect non-zero result if there were
any leftover queries running on the cluster.
Avoid the problem and simplify the test by explicitly waiting for the
number of fragments to go to zero.
Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
---
M tests/query_test/test_lifecycle.py
M tests/verifiers/metric_verifier.py
2 files changed, 5 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/4325/1
--
To view, visit http://gerrit.cloudera.org:8080/4325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4325/1/tests/query_test/test_lifecycle.py
File tests/query_test/test_lifecycle.py:
Line 37: for i in ImpalaCluster().impalads ]
> one line?
Done
Line 53: for i in ImpalaCluster().impalads ]
> one line?
Done
--
To view, visit http://gerrit.cloudera.org:8080/4325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4325/1/tests/query_test/test_lifecycle.py
File tests/query_test/test_lifecycle.py:
Line 37: for i in ImpalaCluster().impalads ]
one line?
Line 53: for i in ImpalaCluster().impalads ]
one line?
--
To view, visit http://gerrit.cloudera.org:8080/4325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4325
to look at the new patch set (#2).
Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
......................................................................
IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
The test previously got the "initial" value of number of fragments by
reading the metric. This gave an incorrect non-zero result if there were
any leftover queries running on the cluster.
Avoid the problem and simplify the test by explicitly waiting for the
number of fragments to go to zero.
Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
---
M tests/query_test/test_lifecycle.py
M tests/verifiers/metric_verifier.py
2 files changed, 5 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/4325/2
--
To view, visit http://gerrit.cloudera.org:8080/4325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
......................................................................
IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
The test previously got the "initial" value of number of fragments by
reading the metric. This gave an incorrect non-zero result if there were
any leftover queries running on the cluster.
Avoid the problem and simplify the test by explicitly waiting for the
number of fragments to go to zero.
Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
Reviewed-on: http://gerrit.cloudera.org:8080/4325
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
---
M tests/query_test/test_lifecycle.py
M tests/verifiers/metric_verifier.py
2 files changed, 5 insertions(+), 18 deletions(-)
Approvals:
Internal Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
......................................................................
Patch Set 2: Code-Review+2
carry +2
--
To view, visit http://gerrit.cloudera.org:8080/4325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I112e502a25f075928b0f6ef376c7fd9c6376ef4d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No